Replace usage of unshift with concat #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to get a better perf results by using
Array.prototype.concatto create a new array with the additional args needed, instead of mutating the value being flattened twice withunshiftandsplice.Results:
I also gave
array.splice.call(array, i,1,...value)a shot which would transpile toarray.call.apply(array.splice, [array, i, 1].concat(value))but the benchmark was about the same.edit: Tests are passing aside from
verify optimizability -> with empty array, which wasn't passing originally on master.