Skip to content

build: remove lodash dependency and use native alternatives #1902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarshallOfSound merged 1 commit into from
Apr 8, 2026
+1 −20
Merged

build: remove lodash dependency and use native alternatives #1902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@
"@tsconfig/node22": "^22.0.2",
"@types/debug": "^4.1.12",
"@types/graceful-fs": "^4.1.9",
"@types/lodash": "^4.17.20",
"@types/node": "~22.10.7",
"@types/parse-author": "^2.0.2",
"@types/plist": "^3.0.5",
Expand All @@ -77,7 +76,6 @@
"eslint-plugin-promise": "^7.2.1",
"husky": "^9.1.7",
"lint-staged": "^16.1.5",
"lodash": "^4.17.21",
"prettier": "^3.6.2",
"tsx": "^4.20.4",
"typedoc": "~0.28.14",
Expand Down
3 changes: 1 addition & 2 deletions test/resedit.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { WindowsApp } from '../src/win32.js';
import _ from 'lodash';
import { describe, it, expect } from 'vitest';

describe('resedit', () => {
Expand Down Expand Up @@ -88,7 +87,7 @@ describe('resedit', () => {
const rcOpts = app.generateReseditOptionsSansIcon();

for (const [key, value] of Object.entries(expectedValues)) {
expect(_.get(rcOpts, key)).toBe(value);
expect(rcOpts).toHaveProperty(key, value);
}
},
);
Expand Down
16 changes: 0 additions & 16 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ __metadata:
"@tsconfig/node22": "npm:^22.0.2"
"@types/debug": "npm:^4.1.12"
"@types/graceful-fs": "npm:^4.1.9"
"@types/lodash": "npm:^4.17.20"
"@types/node": "npm:~22.10.7"
"@types/parse-author": "npm:^2.0.2"
"@types/plist": "npm:^3.0.5"
Expand All @@ -106,7 +105,6 @@ __metadata:
husky: "npm:^9.1.7"
junk: "npm:^4.0.1"
lint-staged: "npm:^16.1.5"
lodash: "npm:^4.17.21"
parse-author: "npm:^2.0.0"
plist: "npm:^3.1.0"
prettier: "npm:^3.6.2"
Expand Down Expand Up @@ -1028,13 +1026,6 @@ __metadata:
languageName: node
linkType: hard

"@types/lodash@npm:^4.17.20":
version: 4.17.20
resolution: "@types/lodash@npm:4.17.20"
checksum: 10c0/98cdd0faae22cbb8079a01a3bb65aa8f8c41143367486c1cbf5adc83f16c9272a2a5d2c1f541f61d0d73da543c16ee1d21cf2ef86cb93cd0cc0ac3bced6dd88f
languageName: node
linkType: hard

"@types/ms@npm:*":
version: 0.7.33
resolution: "@types/ms@npm:0.7.33"
Expand Down Expand Up @@ -4325,13 +4316,6 @@ __metadata:
languageName: node
linkType: hard

"lodash@npm:^4.17.21":
version: 4.17.23
resolution: "lodash@npm:4.17.23"
checksum: 10c0/1264a90469f5bb95d4739c43eb6277d15b6d9e186df4ac68c3620443160fc669e2f14c11e7d8b2ccf078b81d06147c01a8ccced9aab9f9f63d50dcf8cace6bf6
languageName: node
linkType: hard

"log-update@npm:^6.1.0":
version: 6.1.0
resolution: "log-update@npm:6.1.0"
Expand Down
Loading