Skip to content

build: remove lodash dependency and use native alternatives#1902

Merged
MarshallOfSound merged 1 commit intomainfrom
claude/remove-lodash-dependency-wYn9i
Apr 8, 2026
Merged

build: remove lodash dependency and use native alternatives#1902
MarshallOfSound merged 1 commit intomainfrom
claude/remove-lodash-dependency-wYn9i

Conversation

@MarshallOfSound
Copy link
Copy Markdown
Member

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Removes the lodash dependency and replaces its usage with native JavaScript alternatives. Specifically:

  • Replaced _.get(rcOpts, key) with rcOpts and used Vitest's toHaveProperty() matcher to assert both the property existence and value
  • Removed lodash and @types/lodash from package.json dependencies

This reduces the project's dependency footprint while maintaining the same test coverage and functionality. The native toHaveProperty() matcher is more idiomatic for the testing framework being used.

https://preview.claude.ai/code/session_01RP39NKFQFxTbxT8WBRakUB

The only usage was _.get() in test/resedit.spec.ts for nested property
assertions. Replaced with vitest's built-in toHaveProperty matcher,
which supports the same dot-path notation.
@MarshallOfSound MarshallOfSound requested a review from a team as a code owner April 8, 2026 22:49
@MarshallOfSound MarshallOfSound changed the title Remove lodash dependency and use native alternatives build: remove lodash dependency and use native alternatives Apr 8, 2026
Copy link
Copy Markdown
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p nice

@MarshallOfSound MarshallOfSound merged commit 2f53752 into main Apr 8, 2026
8 of 9 checks passed
@MarshallOfSound MarshallOfSound deleted the claude/remove-lodash-dependency-wYn9i branch April 8, 2026 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants