Conversation
When UpdatePrinterSettings() fails (e.g. the printer rejects the requested resolution), OnError() nullifies print_info_ via ReleaseContext(). The return value was not checked, so AskUserForSettings() passed nil to [NSPrintPanel runModalWithPrintInfo:], crashing in PJCSessionHasApplicationSetPrinter with a null PMPrintSession. Check the return value and fall back to UseDefaultSettings() on failure so the dialog opens with defaults instead of crashing. Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
4 tasks
trop
bot
added
42-x-y
backport
samuelmaddock
approved these changes
Apr 9, 2026
VerteDinde
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #50843
See that PR for details.
Notes: Fixed a potential crash when using
webContents.print().