fix: avoid crash in window.print() when prefilling native print dialog#50843
Merged
samuelmaddock merged 1 commit intomainfrom Apr 9, 2026
Merged
fix: avoid crash in window.print() when prefilling native print dialog#50843samuelmaddock merged 1 commit intomainfrom
window.print() when prefilling native print dialog#50843samuelmaddock merged 1 commit intomainfrom
Conversation
codebytere
added
semver/patch
When UpdatePrinterSettings() fails (e.g. the printer rejects the requested resolution), OnError() nullifies print_info_ via ReleaseContext(). The return value was not checked, so AskUserForSettings() passed nil to [NSPrintPanel runModalWithPrintInfo:], crashing in PJCSessionHasApplicationSetPrinter with a null PMPrintSession. Check the return value and fall back to UseDefaultSettings() on failure so the dialog opens with defaults instead of crashing.
codebytere
force-pushed
the
fix-window-print-crash
branch
from
650d737 to
f7d5770
Compare
samuelmaddock
approved these changes
Apr 9, 2026
ckerr
approved these changes
Apr 9, 2026
|
Release Notes Persisted
|
Contributor
|
I was unable to backport this PR to "41-x-y" cleanly; |
trop
bot
added
needs-manual-bp/41-x-y
and removed
target/41-x-y
Contributor
|
I have automatically backported this PR to "42-x-y", please check out #50853 |
trop
bot
added
in-flight/42-x-y
and removed
target/42-x-y
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #50827
When
UpdatePrinterSettings()fails (e.g. the printer rejects the requested resolution),OnError()nullifies print_info_ viaReleaseContext(). The return value was not checked, soAskUserForSettings()passed nil to[NSPrintPanel runModalWithPrintInfo:], crashing inPJCSessionHasApplicationSetPrinterwith a nullPMPrintSession.Check the return value and fall back to
UseDefaultSettings()on failure so the dialog opens with defaults instead of crashing.Checklist
npm testpassesRelease Notes
Notes: Fixed a potential crash when using
webContents.print().