Skip to content

Convert tabs that can be applies-switch#4429

Merged
florent-leborgne merged 19 commits intoelastic:mainfrom
florent-leborgne:convert-tabs-into-applies-switch
Jan 9, 2026
Merged

Convert tabs that can be applies-switch#4429
florent-leborgne merged 19 commits intoelastic:mainfrom
florent-leborgne:convert-tabs-into-applies-switch

Conversation

@florent-leborgne
Copy link
Copy Markdown
Member

Summary

This PR converts tabs that should now be applies-switch thanks to the recent and upcoming updates to the metadata system.

This PR should only be merged after elastic/docs-builder#2322 is merged.

CI should fail until then.

Contributes to: #4361

Generative AI disclosure

  1. Did you use a generative AI (GenAI) tool to assist in creating this contribution?
  • Yes
  • No

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 19, 2025

Vale Linting Results

Summary: 3 suggestions found

💡 Suggestions (3)
File Line Rule Message
troubleshoot/observability/apm/apm-server-response-codes.md 20 Elastic.WordChoice Consider using 'refer to (if it's a document), view (if it's a UI element)' instead of 'See', unless the term is in the UI.
troubleshoot/observability/apm/apm-server-response-codes.md 24 Elastic.WordChoice Consider using 'refer to (if it's a document), view (if it's a UI element)' instead of 'See', unless the term is in the UI.
troubleshoot/observability/troubleshoot-logs.md 49 Elastic.WordChoice Consider using 'refer to (if it's a document), view (if it's a UI element)' instead of 'see', unless the term is in the UI.

@florent-leborgne
Copy link
Copy Markdown
Member Author

florent-leborgne commented Dec 19, 2025

I broke something in there which isn't obvious to find, 🕵️

Edit: found ittttt

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 19, 2025

🔍 Preview links for changed docs

More links …

@benironside
Copy link
Copy Markdown
Contributor

@florent-leborgne , what kind of reviews do you want on this? It's not the typical PR so I'm just thinking about how best to go about it 🕵️

Copy link
Copy Markdown
Member

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most of this looks good, but please skip the elasticsearch troubleshooting content. I'll need to fix it with the page-level issues

Comment thread deploy-manage/autoscaling/trained-model-autoscaling.md Outdated
Comment thread deploy-manage/manage-spaces.md Outdated
Comment thread deploy-manage/security/network-security-api.md
Comment thread deploy-manage/security/private-connectivity-gcp.md Outdated
Comment thread deploy-manage/users-roles/cluster-or-deployment-auth/saml.md
Comment thread get-started/evaluate-elastic.md
Comment thread troubleshoot/elasticsearch/add-tier.md Outdated
Comment thread troubleshoot/elasticsearch/allow-all-cluster-allocation.md Outdated
@shainaraskas
Copy link
Copy Markdown
Member

as a side note, there's only maybe a handful of things in here with a range ... this could be split and most of it could be merged ASAP

Copy link
Copy Markdown
Member

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 dev docs files lgtm

Copy link
Copy Markdown
Member

@mdbirnstiehl mdbirnstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the most part, let me know if you want me to handle the comment I made.

Comment thread solutions/observability/synthetics/create-monitors-with-projects.md Outdated
Copy link
Copy Markdown
Member

@vishaangelova vishaangelova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ingest docs LGTM, left some observations.

Comment thread reference/fleet/elastic-agent-container.md
Comment thread reference/fleet/elastic-agent-container.md Outdated
Comment thread reference/fleet/elastic-agent-container.md Outdated
@florent-leborgne florent-leborgne changed the title [Do not merge] Convert tabs that can be applies-switch Convert tabs that can be applies-switch Jan 8, 2026
Copy link
Copy Markdown
Member

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved apart from the troubleshoot/elasticsearch items, which we are fixing in another PR (please revert to avoid conflicts)

@florent-leborgne florent-leborgne merged commit 7316ede into elastic:main Jan 9, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants