[do not merge] check multi value applies-to and lists #4431
+170
−161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Vale Linting ResultsSummary: 5 suggestions found 💡 Suggestions (5)
|
Contributor
Contributor
|
@florent-leborgne I'll ask the same question as I did on #4429, what kind of reviews do you want on this? It's not the typical PR so I'm just thinking about how best to go about it 🕵️ |
shainaraskas
approved these changes
Dec 22, 2025
Collaborator
shainaraskas
left a comment
shainaraskas
left a comment
There was a problem hiding this comment.
approving to unblock for my teams
bmorelli25
reviewed
Dec 23, 2025
bmorelli25
reviewed
Dec 23, 2025
bmorelli25
reviewed
Dec 23, 2025
bmorelli25
approved these changes
Dec 23, 2025
Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>
Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>
nastasha-solomon
approved these changes
Jan 5, 2026
Contributor
nastasha-solomon
left a comment
nastasha-solomon
left a comment
There was a problem hiding this comment.
Thanks for updating these docs too!
solutions/observability/incident-management/create-manage-rules.md
Outdated
Show resolved
Hide resolved
…s.md Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
florent-leborgne
commented
Jan 6, 2026
leemthompo
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
.0can stay as is, or make necessary adjustments if not.Note: the
+notation is a best practice but isn't mandatory, so this PR does not update every single occurrence of applies_to that we have, and instead focuses on cases with ambiguity or that could have led to issues with the updatesThis PR should only be merged after elastic/docs-builder#2322 is merged.
CI should fail until then.
Contributes to: #4361
Generative AI disclosure