editorconfig/editorconfig#429 Remove section name, key and value length limits by goodhoko · Pull Request #41 · editorconfig/editorconfig-core-test

goodhoko · 2020-05-21T10:12:03Z

Remove the upper limit for section name, key and value length.
Permit implementations to define their own upper limits.
Add minimum supported lengths each implementation must support.

ppalaga · 2020-05-21T11:05:45Z

@goodhoko I do not see a problem when looking at the changes. But to get real certainty I would like to see the changes necessary for ec4j to pass the new tests. Do you happen to have the changes already? Otherwise I can try.

goodhoko · 2020-05-21T19:47:49Z

@ppalaga Validating the tests against an actual implementation would certainly be awesome.

I do not have anything ready yet. So feel free to do that!

ppalaga · 2020-05-21T20:53:12Z

@goodhoko I hope I'll be able to do it in a couple of days.

parser/limits.in

Prepare for editorconfig/editorconfig-core-test#41

ppalaga

ec4j is passing with these changes after I removed the limits ec4j/ec4j#111

cxw42 · 2020-05-26T02:10:24Z

ec-vim passes on my local machine after removing limits: editorconfig/editorconfig-vim#148

cxw42

One question

cxw42 · 2020-05-26T02:11:44Z

parser/limits.in

-[{test4,test00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000004}]
-key=value
+; minimum supported section name length of 1024 characters
+[{test3,aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa}]


There are only 1014 as in this string, and the total length inside the brackets is 1022. If I read https://github.com/editorconfig/specification/pull/21/files#diff-db4b047b30ffef7855b12b527860ac2cR134 correctly, there should be 1024 characters inside the brackets here, correct?

Good catch. The old limit was tied to the length of the glob without brackets - at least that's how it was implemented in ec4j. I wonder if we should make this more explicit in the spec?

I wonder if we should make this more explicit in the spec?

Reading again, I think it is clear enough.

Good catch indeed! I based the tests on the existing ones, but confused test3 and test4. 🤦

I fixed this and also added note in the comment in the limits.in

; minimum supported section name length of 1024 characters (excluding [] brackets)

Reading again, I think it is clear enough.

Agree. It directly follows from

Section Name: the string between the beginning [ and the ending ].

@cxw42 can you take a look at this, please? I believe it should be all good now.

I also run the 'limitless branch' of ec4j against this branch and everything passed. (thanks @ppalaga )

ppalaga · 2020-06-18T19:18:55Z

@cxw42 isn't this good to merge?

Mpdreamz

😸 LGTM

cxw42 · 2020-07-19T02:04:55Z

@ppalaga I think we have enough successes that the spec change could now be put to a vote. I see there are some merge conflicts to be resolved @goodhoko

…th limits - Remove the upper limit for section name, key and value length. - Permit implementations to define their own upper limits. - Add minimum supported lengths each implementation must support.

goodhoko · 2020-07-21T12:42:46Z

@cxw42 Rebased.

Prepare for editorconfig/editorconfig-core-test#41

xuhdev · 2020-12-02T22:50:37Z

Should be be ready to be merged yet?

cxw42 · 2020-12-04T22:13:17Z

@xuhdev pending editorconfig/specification#21, but other than that, I think it's probably fine. The only thing is that I have not had a chance to investigate the Windows test failures on editorconfig-vim (my apologies!), but I agree we can proceed anyway.

xuhdev · 2020-12-05T07:14:21Z

Sorry for the delay -- sometimes I miss notification or forget things. I've started a polling: editorconfig/editorconfig-vote#13

Feel free to ping me next time -- I'm never tired of reminders!

goodhoko · 2020-12-28T10:46:45Z

@xuhdev since editorconfig/specification#21 is merged, this should be merged as well to keep the spec and tests in sync. .)

xuhdev · 2020-12-28T22:07:55Z

Thanks for your contributions! Sorry for having missed this PR earlier.

Prepare for editorconfig/editorconfig-core-test#41

Increase the minimum key and value lengths to pass the tests added in <editorconfig/editorconfig-core-test#41>.

goodhoko mentioned this pull request May 21, 2020

What is the motivation to have hard limits on section and property [name] length? editorconfig/editorconfig#429

Closed

goodhoko changed the title ~~editorconfig/editorconfig#429 Remove sectio name, key and value length limits~~ editorconfig/editorconfig#429 Remove section name, key and value length limits May 21, 2020

goodhoko force-pushed the feature/remove-length-limits branch from f6950b4 to a433049 Compare May 21, 2020 11:18

cxw42 reviewed May 22, 2020

View reviewed changes

parser/limits.in Outdated Show resolved Hide resolved

goodhoko force-pushed the feature/remove-length-limits branch from a433049 to d2ece77 Compare May 22, 2020 13:54

ppalaga added a commit to ppalaga/ec4j that referenced this pull request May 22, 2020

Remove section, key and value length limits

271ebcc

Prepare for editorconfig/editorconfig-core-test#41

ppalaga mentioned this pull request May 22, 2020

Remove section, key and value length limits ec4j/ec4j#111

Merged

ppalaga approved these changes May 22, 2020

View reviewed changes

cxw42 requested changes May 26, 2020

View reviewed changes

goodhoko force-pushed the feature/remove-length-limits branch 2 times, most recently from 52b565e to a4fcbb3 Compare May 26, 2020 09:36

ppalaga mentioned this pull request May 26, 2020

Remove length limits on sections/keys/values editorconfig/editorconfig-vim#148

Draft

Mpdreamz approved these changes Jul 7, 2020

View reviewed changes

cxw42 approved these changes Jul 19, 2020

View reviewed changes

editorconfig/editorconfig#429 Remove section name, key and value leng…

cf3a942

…th limits - Remove the upper limit for section name, key and value length. - Permit implementations to define their own upper limits. - Add minimum supported lengths each implementation must support.

goodhoko force-pushed the feature/remove-length-limits branch from a4fcbb3 to cf3a942 Compare July 21, 2020 12:41

ppalaga added a commit to ppalaga/ec4j that referenced this pull request Jul 27, 2020

Remove section, key and value length limits

c318f00

Prepare for editorconfig/editorconfig-core-test#41

ffes mentioned this pull request Aug 26, 2020

Segfault while reading .editorconfig generated by JetBrains IDE editorconfig/editorconfig-core-c#73

Closed

greut mentioned this pull request Aug 27, 2020

fix: prevent buffer overflow editorconfig/editorconfig-core-c#74

Merged

ppalaga mentioned this pull request Dec 28, 2020

Fail when property value is longer then 255 characters ec4j/ec4j#118

Closed

xuhdev merged commit 70840cf into editorconfig:master Dec 28, 2020

ppalaga added a commit to ppalaga/ec4j that referenced this pull request Dec 28, 2020

Remove section, key and value length limits

4d520cc

Prepare for editorconfig/editorconfig-core-test#41

ppalaga added a commit to ppalaga/ec4j that referenced this pull request Dec 28, 2020

Remove section, key and value length limits

0968b9d

Prepare for editorconfig/editorconfig-core-test#41

ppalaga added a commit to ppalaga/ec4j that referenced this pull request Dec 28, 2020

Remove section, key and value length limits

faa5bc2

Prepare for editorconfig/editorconfig-core-test#41

ppalaga added a commit to ppalaga/ec4j that referenced this pull request Dec 28, 2020

Remove section, key and value length limits

29bb074

Prepare for editorconfig/editorconfig-core-test#41

ppalaga added a commit to ppalaga/ec4j that referenced this pull request Dec 28, 2020

Remove section, key and value length limits

e1878dc

Prepare for editorconfig/editorconfig-core-test#41

goodhoko mentioned this pull request Dec 28, 2020

Support key, values and section names of arbitrary length editorconfig/editorconfig-core-py#36

Open

ppalaga added a commit to ppalaga/ec4j that referenced this pull request Dec 28, 2020

Remove section, key and value length limits

6111e87

Prepare for editorconfig/editorconfig-core-test#41

goodhoko mentioned this pull request Feb 11, 2021

Support key, values and section names of arbitrary length editorconfig/editorconfig-core-ruby#8

Open

cxw42 added a commit to cxw42/editorconfig-core-c that referenced this pull request Oct 30, 2022

Update property key, value length limits per spec change

16d1d92

Increase the minimum key and value lengths to pass the tests added in <editorconfig/editorconfig-core-test#41>.

cxw42 mentioned this pull request Oct 30, 2022

Update tests; increase min key/value lengths editorconfig/editorconfig-core-c#84

Merged

cxw42 added a commit to cxw42/editorconfig-vim that referenced this pull request Oct 31, 2022

Update property key, value length limits per spec change

89ca35f

Increase the minimum key and value lengths to pass the tests added in <editorconfig/editorconfig-core-test#41>.

cxw42 mentioned this pull request Oct 31, 2022

core: Update tests; fix bugs editorconfig/editorconfig-vim#199

Merged

Conversation

goodhoko commented May 21, 2020

Uh oh!

ppalaga commented May 21, 2020

Uh oh!

goodhoko commented May 21, 2020

Uh oh!

ppalaga commented May 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

ppalaga left a comment

Choose a reason for hiding this comment

Uh oh!

cxw42 commented May 26, 2020

Uh oh!

cxw42 left a comment

Choose a reason for hiding this comment

Uh oh!

cxw42 May 26, 2020

Choose a reason for hiding this comment

Uh oh!

ppalaga May 26, 2020

Choose a reason for hiding this comment

Uh oh!

ppalaga May 26, 2020

Choose a reason for hiding this comment

Uh oh!

goodhoko May 26, 2020

Choose a reason for hiding this comment

Uh oh!

goodhoko Jun 9, 2020

Choose a reason for hiding this comment

Uh oh!

ppalaga commented Jun 18, 2020

Uh oh!

Mpdreamz left a comment

Choose a reason for hiding this comment

Uh oh!

cxw42 commented Jul 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

goodhoko commented Jul 21, 2020

Uh oh!

xuhdev commented Dec 2, 2020

Uh oh!

cxw42 commented Dec 4, 2020

Uh oh!

xuhdev commented Dec 5, 2020

Uh oh!

goodhoko commented Dec 28, 2020

Uh oh!

xuhdev commented Dec 28, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ppalaga commented May 21, 2020 •

edited

Loading

cxw42 commented Jul 19, 2020 •

edited

Loading