fix: prevent buffer overflow

[greut]

There is probably a better way though.

Closes #73

[xuhdev]

The test max_property_name is broken:

[00:03:37] test 160
[00:03:37]         Start 160: max_property_name
[00:03:37] 
[00:03:37] 160: Test command: C:\projects\editorconfig-core-c\bin\x64-static\core\bin\Release\editorconfig.exe "-f" "limits.in" "C:/projects/editorconfig-core-c/tests/parser/test1"
[00:03:37] 160: Test timeout computed to be: 10000000
[00:03:37] 160: 00000000000000000000000000000000000000000000000001��n�=50
[00:03:37] 160/189 Test #160: max_property_name .........................***Failed  Required regular expression not found. Regex=[^00000000000000000000000000000000000000000000000001=50[ 	
[00:03:37] 
[00:03:37] ]*$
[00:03:37] ]  0.01 sec
[00:03:37] 00000000000000000000000000000000000000000000000001��n�=50

[Vogtinator]

Why not just use a dynamically allocated string here? Currently it silently truncates and

somelong...name = bar
somelong...namefoo = foo

Would end up parsed as somelongname=foo.

[greut]

Why not just use a dynamically allocated string here?

It would make sense to already implement that proposed change, indeed. editorconfig/editorconfig-core-test#41

However, the goal here is to avoid the buffer overflow.

[Vogtinator]

Actually, looking at the code the allocation can actually be avoided at that point - just use strcasecmp in find_name_value_from_name. Later, set_name_value does a strdup anyway, so that could take care of strlwr as well.

[xuhdev]

This is a point that I missed in the original implementation. Thanks!