Skip to content

fix: prevent buffer overflow #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xuhdev merged 2 commits into from
Aug 27, 2020
Merged

fix: prevent buffer overflow #74

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e322438
fix: prevent buffer overflow
greut Aug 26, 2020
836830e
fixup! fix: prevent buffer overflow
greut Aug 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lib/editorconfig.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ static int array_editorconfig_name_value_add(
int name_value_pos;
/* always use name_lwr but not name, since property names are case
* insensitive */
char name_lwr[MAX_PROPERTY_NAME];
char name_lwr[MAX_PROPERTY_NAME+1] = {0};
Copy link
Copy Markdown
Member

@xuhdev xuhdev Aug 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a point that I missed in the original implementation. Thanks!

/* For the first time we came here, aenv->name_values is NULL */
if (aenv->name_values == NULL) {
aenv->name_values = (editorconfig_name_value*)malloc(
Expand All @@ -153,7 +153,7 @@ static int array_editorconfig_name_value_add(


/* name_lwr is the lowercase property name */
strlwr(strcpy(name_lwr, name));
strlwr(strncpy(name_lwr, name, MAX_PROPERTY_NAME));

name_value_pos = find_name_value_from_name(
aenv->name_values, aenv->current_value_count, name_lwr);
Expand Down