Skip to content

fix(com/impl): fix clang-tidy warnings for fields #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sahithi-nukala wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −3
Open

fix(com/impl): fix clang-tidy warnings for fields #367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .clang-tidy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,6 @@ Checks: >
clang-analyzer-cplusplus.NewDelete,
# --- qnx-checks ---
bugprone-reserved-identifier,
# --- extra ---
modernize-concat-nested-namespaces,

WarningsAsErrors: >
clang-analyzer-*,
Expand Down
2 changes: 1 addition & 1 deletion score/mw/com/impl/skeleton_field.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ class SkeletonField : public SkeletonFieldBase
static_assert(std::is_invocable_v<CallableType, FieldType&>,
"RegisterSetHandler: handler must be callable as void(FieldType& value). "
"The argument initially holds the proxy-requested value and may be modified in-place.");
set_handler_ = std::move(handler);
set_handler_ = std::forward<CallableType>(handler);

auto wrapped_callback = [this](FieldType& new_value) -> FieldType {
// Allow user to validate/modify the value in-place
Expand Down