fix(com/impl): fix clang-tidy warnings for fields#367
Open
sahithi-nukala wants to merge 1 commit intoeclipse-score:mainfrom
Open
fix(com/impl): fix clang-tidy warnings for fields#367sahithi-nukala wants to merge 1 commit intoeclipse-score:mainfrom
sahithi-nukala wants to merge 1 commit intoeclipse-score:mainfrom
Conversation
sahithi-nukala
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
sahithi-nukala
force-pushed
the
sah_fixing_clang_warnings_for_fields
branch
from
486f24e to
8178882
Compare
bemerybmw
requested changes
Apr 28, 2026
| @@ -24,7 +24,7 @@ class SomeIpFieldInstanceDeployment | |||
| SomeIpFieldInstanceDeployment() noexcept = default; | |||
| explicit SomeIpFieldInstanceDeployment(const score::json::Object& /* json_object */) noexcept {} | |||
|
|
|||
| json::Object Serialize() const noexcept | |||
Contributor
There was a problem hiding this comment.
Why is this made static?
| @@ -35,31 +34,17 @@ class IProxyFieldBindingFactory | |||
| virtual ~IProxyFieldBindingFactory() noexcept = default; | |||
|
|
|||
| IProxyFieldBindingFactory(IProxyFieldBindingFactory&&) = delete; | |||
Contributor
There was a problem hiding this comment.
We should discuss whether this clang tidy warning makes sense. I don't think it does in this case.
| IProxyFieldBindingFactory(const IProxyFieldBindingFactory&) = delete; | ||
| IProxyFieldBindingFactory& operator=(const IProxyFieldBindingFactory&) = delete; | ||
| auto operator=(const IProxyFieldBindingFactory&) -> IProxyFieldBindingFactory& = delete; | ||
|
|
||
| /// Creates instances of the event binding of a proxy field with a particular data type. | ||
| /// \tparam SampleType Type of the data that is exchanges | ||
| /// \param handle The handle containing the binding information. | ||
| /// \param field_name The binding unspecific name of the event inside the proxy denoted by handle. | ||
| /// \return An instance of ProxyEventBinding or nullptr in case of an error. |
Contributor
There was a problem hiding this comment.
Why did you remove const?
sahithi-nukala
force-pushed
the
sah_fixing_clang_warnings_for_fields
branch
from
8178882 to
746d8e3
Compare
sahithi-nukala
force-pushed
the
sah_fixing_clang_warnings_for_fields
branch
from
746d8e3 to
769c7f2
Compare
sahithi-nukala
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as it already exists in the extra clang-tidy configuration