Skip to content

[24263] Fix TinyXML2 library resolution in tests#6329

Open
raulojeda22 wants to merge 5 commits intomasterfrom
fix/upgrade_example_tests
Open

[24263] Fix TinyXML2 library resolution in tests#6329
raulojeda22 wants to merge 5 commits intomasterfrom
fix/upgrade_example_tests

Conversation

@raulojeda22
Copy link
Contributor

Description

On Ubuntu 24.04, TinyXML2 is found via CMake config mode, setting TINYXML2_LIBRARY to the target name tinyxml2::tinyxml2 instead of a file path. This caused get_filename_component to produce an empty directory, resulting in broken Docker volume mounts and missing LD_LIBRARY_PATH entries for all example tests. The fix extracts the actual library path from the imported target properties.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Raül <raulojeda@eprosima.com>
@raulojeda22 raulojeda22 requested review from richiprosima and removed request for richiprosima March 13, 2026 08:58
@github-actions github-actions bot added the ci-pending PR which CI is running label Mar 13, 2026
Signed-off-by: Raül <raulojeda@eprosima.com>
@raulojeda22 raulojeda22 changed the title [24263] Fix TinyXML2 library resolution in example tests. [24263] Fix TinyXML2 library resolution in tests Mar 13, 2026
@raulojeda22 raulojeda22 requested review from richiprosima and removed request for richiprosima March 13, 2026 09:30
@mergify
Copy link
Contributor

mergify bot commented Mar 13, 2026

🧪 CI Insights

Here's what we observed from your CI run for c7ef33f.

❌ Job Failures

Pipeline Job Health on master Retries 🔍 CI Insights 📄 Logs
Fast DDS MacOS CI mac-ci / fastdds_test () Unknown 0 View View
Fast DDS Windows CI windows-ci / fastdds_test (RelWithDebInfo, examples), v142 Unknown 0 View View
windows-ci / fastdds_test (RelWithDebInfo, examples), v143 Unknown 0 View View

Signed-off-by: Raül <raulojeda@eprosima.com>
@raulojeda22 raulojeda22 requested review from richiprosima and removed request for richiprosima March 16, 2026 06:28
Signed-off-by: Raül <raulojeda@eprosima.com>
@raulojeda22 raulojeda22 requested review from richiprosima and removed request for richiprosima March 17, 2026 10:34
@@ -0,0 +1,28 @@
# Copyright 2024 Proyectos y Sistemas de Mantenimiento SL (eProsima).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update copyright year because it is a new file.

Signed-off-by: Raül <raulojeda@eprosima.com>
@raulojeda22 raulojeda22 requested review from richiprosima and removed request for richiprosima March 17, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants