[24263] Fix TinyXML2 library resolution in tests#6329
Open
raulojeda22 wants to merge 5 commits intomasterfrom
Open
[24263] Fix TinyXML2 library resolution in tests#6329raulojeda22 wants to merge 5 commits intomasterfrom
raulojeda22 wants to merge 5 commits intomasterfrom
Conversation
Signed-off-by: Raül <raulojeda@eprosima.com>
Signed-off-by: Raül <raulojeda@eprosima.com>
Contributor
🧪 CI InsightsHere's what we observed from your CI run for c7ef33f. ❌ Job Failures
|
Signed-off-by: Raül <raulojeda@eprosima.com>
Signed-off-by: Raül <raulojeda@eprosima.com>
richiware
requested changes
Mar 17, 2026
test/examples/ubuntu/Dockerfile
Outdated
| @@ -0,0 +1,28 @@ | |||
| # Copyright 2024 Proyectos y Sistemas de Mantenimiento SL (eProsima). | |||
Member
There was a problem hiding this comment.
Update copyright year because it is a new file.
Signed-off-by: Raül <raulojeda@eprosima.com>
richiware
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On Ubuntu 24.04, TinyXML2 is found via CMake config mode, setting TINYXML2_LIBRARY to the target name
tinyxml2::tinyxml2instead of a file path. This causedget_filename_componentto produce an empty directory, resulting in broken Docker volume mounts and missing LD_LIBRARY_PATH entries for all example tests. The fix extracts the actual library path from the imported target properties.Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist