-
Notifications
You must be signed in to change notification settings - Fork 31
NTP: Expand screenshot tests #2096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Wed, 10 Dec 2025 22:42:35 GMT IntegrationFile has changed |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Cursor Agent can help with this pull request. Just |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
shakyShane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noisysocks thanks for this!
I agree we should increase the coverage - but my request is that we optimise the approach for future debugging/changes instead. I think in this case we should use playwrights projects/fixtures support to avoid the forEach calls in the code.
Tests are the place I don’t want to be DRY, I want debugging super powers instead.
That might mean setting up a project for light screenshots, and then dark etc. I’m not sure exactly on how to solve this, but anything that removes the loops will work.
special-pages/pages/new-tab/integration-tests/new-tab.screenshots.spec.js
Outdated
Show resolved
Hide resolved
0d57b20 to
13605b5
Compare
Asana Task/Github Issue:
Description
Expands the NTP screenshot tests to cover more states. That way we can be more confident that #2095 isn’t breaking anything.
Testing Steps
n/a
Checklist
Please tick all that apply:
Note
Greatly expands NTP screenshot coverage, makes
omnibarvisible by default (hide withomnibar=false), adds array query param support, and updates tests/config accordingly.ntp-screenshots-lightandntp-screenshots-darkwith set viewport and color scheme.initialSetupto includeomnibarby default; only omit whenomnibar='false'.NewtabPage.openPagesupports array values inadditional(appends multiple params).omnibarinwidgets_setConfigand context menu.omnibar: 'false'where needed for deterministic focus order.Written by Cursor Bugbot for commit 5943ec7. This will update automatically on new commits. Configure here.