NTP: Expand screenshot tests (#2096)

* Default ?omnibar to true

* Expand NTP screenshot tests

* Add CPM snapshots

* Use playwright projects instead of forEach

* Disable omnibar in favorites int tests

Author: noisysocks

special-pages/pages/new-tab/app/favorites/integration-tests/favorites.spec.js

@@ -69,15 +69,16 @@ test.describe('newtab favorites', () => {
         const ntp = NewtabPage.create(page, workerInfo);
         const favorites = new FavoritesPage(ntp);
         await ntp.reducedMotion();
-        await ntp.openPage();
+        await ntp.openPage({ additional: { omnibar: 'false' } });
         await favorites.tabsThroughItems();
     });
     test('initial empty state', async ({ page }, workerInfo) => {
         const ntp = NewtabPage.create(page, workerInfo);
         const favorites = new FavoritesPage(ntp);
         await ntp.reducedMotion();
         // Use cpm: 'null' to enable new UI with InfoIcon for tab navigation test
-        await ntp.openPage({ favorites: 0, additional: { cpm: 'null' } });
+        // Use omnibar: 'false' to hide omnibar so tab order is predictable
+        await ntp.openPage({ favorites: 0, additional: { cpm: 'null', omnibar: 'false' } });
         await favorites.tabsPastEmptyFavorites();
     });
     test('re-orders items', async ({ page }, workerInfo) => {

special-pages/pages/new-tab/app/mock-transport.js

@@ -585,7 +585,7 @@ export function initialSetup(url) {
     widgetsFromStorage.push({ id: 'protections' });
     widgetConfigFromStorage.push({ id: 'protections', visibility: 'visible' });
 
-    if (url.searchParams.has('omnibar')) {
+    if (url.searchParams.get('omnibar') !== 'false') {
         const favoritesWidgetIndex = widgetsFromStorage.findIndex((widget) => widget.id === 'favorites') ?? 0;
         widgetsFromStorage.splice(favoritesWidgetIndex, 0, { id: 'omnibar' });
         const favoritesWidgetConfigIndex = widgetConfigFromStorage.findIndex((widget) => widget.id === 'favorites') ?? 0;

special-pages/pages/new-tab/app/protections/integrations-tests/protections.screenshots.spec.js-snapshots/protections-activity-integration-darwin.png

@@ -123,7 +123,13 @@ export class NewtabPage {
         }
 
         for (const [key, value] of Object.entries(additional || {})) {
-            searchParams.set(key, value);
+            if (Array.isArray(value)) {
+                for (const item of value) {
+                    searchParams.append(key, item);
+                }
+            } else {
+                searchParams.set(key, value);
+            }
         }
 
         // eslint-disable-next-line no-undef