Fix potential null pCommonAssemImport handling in ImportTypeRef#126151
Open
tpa95 wants to merge 3 commits intodotnet:mainfrom
Open
Fix potential null pCommonAssemImport handling in ImportTypeRef#126151tpa95 wants to merge 3 commits intodotnet:mainfrom
tpa95 wants to merge 3 commits intodotnet:mainfrom
Conversation
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @agocke, @elinor-fung |
jkotas
reviewed
Mar 26, 2026
| &tkOuterEmitRes)); | ||
| } | ||
| else if (TypeFromToken(tkImplementation) == mdtAssemblyRef) | ||
| if (pCommonAssemImport != NULL) |
Member
There was a problem hiding this comment.
The other invariants in the code should guarantee that this is never null.
If this was ever null, it is better to crash or return error rather than silently misbehaving.
Contributor
Author
There was a problem hiding this comment.
@jkotas Thanks for the review. Just to make sure I understand the expected direction: would you prefer to rely on the invariant that pCommonAssemImport is never null here, or to handle a null value explicitly with an assert/error path rather than a silent check?
jkotas
requested changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Static analysis reported that pCommonAssemImport may be null on a path that reaches CreateAssemblyRefFromAssembly, where it is dereferenced. Add a null check before using pCommonAssemImport to avoid dereferencing a null assembly import interface.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Reporter: Pavel Tikhomirov (Tihomirov-P@gaz-is.ru).
Organization: Gazinformservice (resp@gaz-is.ru).