[Sonic] Remove DesignTime ability and suppression from source generator#12847
Draft
chsienki wants to merge 2 commits intodotnet:mainfrom
Draft
[Sonic] Remove DesignTime ability and suppression from source generator#12847chsienki wants to merge 2 commits intodotnet:mainfrom
chsienki wants to merge 2 commits intodotnet:mainfrom
Conversation
chsienki
changed the title
chsienki
force-pushed
the
sonic/1_generator_cleanup
branch
from
7fbc887 to
319159c
Compare
| var metadataRefs = context.MetadataReferencesProvider; | ||
|
|
||
| // We might get initialized before razor tooling has a chance to set this, so check it any time something changes. It's extremely cheap and we'll stop propagating directly below if it didn't changed. | ||
| var useRazorCohostServer = context.AdditionalTextsProvider.Collect().Combine(context.CompilationProvider).Select((_, _) => RazorCohostingOptions.UseRazorCohostServer); |
Member
There was a problem hiding this comment.
Should we remove this too while you're in here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup the source generator:
Remove the ability to produce design time documents
Remove the ability to suppress the generator:
These are in two commits so probably easiest to review each one. There is a bunch of white space change too where indentation changed so probably want to ignore whitespace in the diffs.