Skip to content

fix(nix): Fix Nix on MacOS #1610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeff-hykin merged 1 commit into from
Mar 19, 2026
+12 −4
Merged

fix(nix): Fix Nix on MacOS #1610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions flake.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,10 +160,18 @@
nativeBuildInputs = (old.nativeBuildInputs or []) ++ [ pkgs.pkg-config pkgs.python312 ];
# 1. fix pkg-config on darwin
env.PKG_CONFIG_PATH = packageConfPackagesString;
# 2. Fix fsync on darwin
patches = [
(pkgs.writeText "lcm-darwin-fsync.patch" "--- ./lcm-logger/lcm_logger.c 2025-11-14 09:46:01.000000000 -0600\n+++ ./lcm-logger/lcm_logger.c 2025-11-14 09:47:05.000000000 -0600\n@@ -428,9 +428,13 @@\n if (needs_flushed) {\n fflush(logger->log->f);\n #ifndef WIN32\n+#ifdef __APPLE__\n+ fsync(fileno(logger->log->f));\n+#else\n // Perform a full fsync operation after flush\n fdatasync(fileno(logger->log->f));\n #endif\n+#endif\n logger->last_fflush_time = log_event->timestamp;\n }\n")
];
# Remove upstream patches (the darwin-fsync patch causes "out of memory" in patch utility)
patches = [];
# 2. Fix fsync on darwin (use substituteInPlace to avoid patch utility issues)
postPatch = (old.postPatch or "") + ''
substituteInPlace lcm-logger/lcm_logger.c \
--replace-fail 'fdatasync(fileno(logger->log->f));' \
'#ifdef __APPLE__
fsync(fileno(logger->log->f));
#else
fdatasync(fileno(logger->log->f));
#endif'
'';
}
);
}
Expand Down
Loading