Skip to content

fix(SuggestionInput): remove unsupported props #4883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mimarz wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(SuggestionInput): remove unsupported props #4883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
743da80
fix(SuggestionInput): remove unsupported props
mimarz May 13, 2026
4a49cd9
add changeset
mimarz May 13, 2026
f556870
Apply suggestions from code review
Barsnes May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/quiet-birds-attend.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@digdir/designsystemet-react": minor
---

**SuggestionInput:** Remove unsupported props `role` and `data-indeterminate` that would break `Suggestion`
5 changes: 4 additions & 1 deletion packages/react/src/components/suggestion/suggestion-input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,10 @@ import { forwardRef, useContext, useEffect } from 'react';
import { Input, type InputProps } from '../input/input';
import { SuggestionContext } from './suggestion';

export type SuggestionInputProps = InputProps;
export type SuggestionInputProps = Omit<
InputProps,
'role' | 'data-indeterminate'
>;

// Make React support popovertarget attribute
// https://github.com/facebook/react/issues/27479
Expand Down
Loading