Skip to content

fix(SuggestionInput): remove unsupported props#4883

Open
mimarz wants to merge 3 commits into
mainfrom
fix-suggestion-props
Open

fix(SuggestionInput): remove unsupported props#4883
mimarz wants to merge 3 commits into
mainfrom
fix-suggestion-props

Conversation

@mimarz
Copy link
Copy Markdown
Collaborator

@mimarz mimarz commented May 13, 2026

When reviewing #4867 with @eirikbacker we discovered some props that would break Suggestion if used.

Remove them from props to avoid misuse.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 13, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f417deaf-d0b3-429d-8d28-f1ca7ff8c036

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-suggestion-props

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 13, 2026

🦋 Changeset detected

Latest commit: f556870

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@digdir/designsystemet-react Minor
@digdir/designsystemet Minor
@digdir/designsystemet-css Minor
@digdir/designsystemet-types Minor
@digdir/designsystemet-web Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

Preview deployments for this pull request:

storybook - 15. May 2026 - 07:47

@mimarz mimarz requested a review from Copilot May 13, 2026 12:20
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR narrows the public SuggestionInput prop surface in @digdir/designsystemet-react to prevent passing props that can break the underlying Suggestion behavior.

Changes:

  • Updated SuggestionInputProps to omit unsupported InputProps keys (role, data-indeterminate).
  • Added a changeset documenting the change for @digdir/designsystemet-react.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
packages/react/src/components/suggestion/suggestion-input.tsx Restricts SuggestionInputProps by omitting problematic InputProps keys.
.changeset/quiet-birds-attend.md Declares the package version bump and describes the SuggestionInput prop change.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .changeset/quiet-birds-attend.md Outdated
Comment thread .changeset/quiet-birds-attend.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants