fix(SuggestionInput): remove unsupported props#4883
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🦋 Changeset detectedLatest commit: f556870 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Preview deployments for this pull request: storybook - |
There was a problem hiding this comment.
Pull request overview
This PR narrows the public SuggestionInput prop surface in @digdir/designsystemet-react to prevent passing props that can break the underlying Suggestion behavior.
Changes:
- Updated
SuggestionInputPropsto omit unsupportedInputPropskeys (role,data-indeterminate). - Added a changeset documenting the change for
@digdir/designsystemet-react.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/react/src/components/suggestion/suggestion-input.tsx | Restricts SuggestionInputProps by omitting problematic InputProps keys. |
| .changeset/quiet-birds-attend.md | Declares the package version bump and describes the SuggestionInput prop change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
When reviewing #4867 with @eirikbacker we discovered some props that would break
Suggestionif used.Remove them from props to avoid misuse.