feat: implement question tool modal (fixes #273)#434
Merged
benjaminshafii merged 1 commit intodifferent-ai:devfrom Feb 4, 2026
Merged
feat: implement question tool modal (fixes #273)#434benjaminshafii merged 1 commit intodifferent-ai:devfrom
benjaminshafii merged 1 commit intodifferent-ai:devfrom
Conversation
- Add PendingQuestion type to types.ts - Add question event handling in session.ts (question.asked, question.replied, question.rejected) - Add pendingQuestions store, activeQuestion computed, questionReplyBusy signal - Add respondQuestion and rejectQuestion API methods - Create QuestionModal component with: - Sequential wizard flow (Question X of Y) - Keyboard navigation (Arrow Up/Down + Enter) - Multi-select and custom input support - Auto-advance for single-select options - Integrate QuestionModal in session.tsx - Wire up props in app.tsx
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
Member
|
thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #273 - Question tool modal does not appear (blocks workflow)
Changes
Types (
types.ts)QuestionRequestimport from SDKPendingQuestiontype withreceivedAttimestampState Management (
context/session.ts)pendingQuestionsto store statequestion.asked,question.replied,question.rejectedrefreshPendingQuestions()to fetch pending questionsactiveQuestioncomputed (per-session or global first pending)questionReplyBusysignal for busy staterespondQuestion()andrejectQuestion()API methodsUI (
components/question-modal.tsx)QuestionModalcomponent with:custom: trueIntegration
session.tsx: RenderedQuestionModalwith props from storeapp.tsx: Wired upactiveQuestion,questionReplyBusy,respondQuestionTesting
pnpm dev:uiTypeScript Build