Skip to content

fix: deflake xnet_slo_120 test by allocating to Dells only and doubling vCPUs #10552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
basvandijk wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −1
Open

fix: deflake xnet_slo_120 test by allocating to Dells only and doubling vCPUs #10552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rs/tests/message_routing/xnet/slo_test_lib/xnet_slo_test_lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ impl Config {
// Generic setup
fn setup(env: TestEnv, config: Config) {
let ic = InternetComputer::new()
.with_required_host_features(vec![HostFeature::Performance])
.with_required_host_features(vec![HostFeature::Performance, HostFeature::Dell])
.with_resource_overrides(config.vm_resource_overrides);
(0..config.subnets)
.fold(ic, |ic, _idx| {
Expand Down
5 changes: 5 additions & 0 deletions rs/tests/message_routing/xnet/xnet_slo_120_subnets_staging_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
use anyhow::Result;
use ic_system_test_driver::driver::group::SystemTestGroup;
use ic_system_test_driver::driver::ic::{NrOfVCPUs, VmResourceOverrides};
use ic_system_test_driver::systest;
use std::time::Duration;
use xnet_slo_test_lib::Config;
Expand All @@ -14,6 +15,10 @@ const OVERALL_TIMEOUT: Duration = Duration::from_secs(1400);

fn main() -> Result<()> {
let config = Config::new(SUBNETS, NODES_PER_SUBNET, RUNTIME, REQUEST_RATE)
.with_resource_overrides(VmResourceOverrides {
vcpus: Some(NrOfVCPUs::new(12)),
..VmResourceOverrides::default()
})
// Only best-effort calls with 30 seconds timeout, so the test doesn't hang for
// minutes in case we can't connect to some replica/subnet to pull.
.with_call_timeouts(&[Some(30)]);
Expand Down
Loading