fix: deflake xnet_slo_120 test by allocating to Dells only and doubling vCPUs#10552
Open
basvandijk wants to merge 1 commit into
Open
fix: deflake xnet_slo_120 test by allocating to Dells only and doubling vCPUs#10552basvandijk wants to merge 1 commit into
basvandijk wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
//rs/tests/message_routing/xnet:xnet_slo_120_subnets_staging_test_colocateis 50% flaky since the send rate on some subnets is often below the minimum of 0.3.As an experiment to fix this we force allocation of IC nodes to the more performant Dell hosts to not mix in the slightly slower Supermicros. We also double the number of vCPUs for IC nodes from 6 to 12 to give the VMs a bit more capacity.
If this doesn't make the test more stable we could try labelling the test with
cpu:64so no othersystem_test_largetests will run at the same time ensuring the hosts are more idle to get more consistent performance characteristics.Passing manual run: BuildBuddy.