Open
Conversation
The `testonly` tag was used very liberally throughout the codebase, and was applied to many targets that definitely were not test only (like ic-admin, published pocket-ic executables, etc). This removes some of the uses of `testonly` (it tends to spread like wildfire).
Contributor
Author
|
(will need to update the cargo deps as well) |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
basvandijk
approved these changes
May 8, 2026
Collaborator
basvandijk
left a comment
basvandijk
left a comment
There was a problem hiding this comment.
I remember there was some reason to mark them as testonly but can't remember the details. But I guess if CI passes it's good!
|
|
||
| rust_library( | ||
| name = "test_utils", | ||
| testonly = True, |
Contributor
There was a problem hiding this comment.
A lot of them, like this one, is in a directory containing test_utils. Shouldn't we keep them for those?
Contributor
Author
There was a problem hiding this comment.
Good catch, I'll need to double check this. Might have been too zealous.
Bownairo
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
testonlytag was used very liberally throughout the codebase, and was applied to many targets that definitely were not test only (like ic-admin, published pocket-ic executables, etc). This removes some of the uses oftestonly(it tends to spread like wildfire).