Skip to content

#1456 : Fix uninstall via windows settings bug #1865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KarimALotfy wants to merge 9 commits into
base: main
Choose a base branch
from
+9 −3
Open

#1456 : Fix uninstall via windows settings bug #1865

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d945e9a
#1456: update uninstall command
KarimALotfy Apr 24, 2026
8426789
fix: update uninstall command to use INSTALLFOLDER variable
KarimALotfy Apr 27, 2026
60b075f
#1456: create test MSI identity for uninstall verification
KarimALotfy Apr 27, 2026
6d9673e
#1456: create test MSI identity with a modified guiid code
KarimALotfy Apr 27, 2026
49e8c4c
#1456:revert change of code and name
KarimALotfy Apr 27, 2026
d7820b1
#1456: refactor uninstall process on Windows by checking for bash ava…
KarimALotfy Apr 27, 2026
490a974
#1456: revert change of ProductName
KarimALotfy Apr 28, 2026
625b623
Merge branch "main" into "feature/1456-uninstall-via-windows-settings…
KarimALotfy Apr 28, 2026
3017017
Merge branch 'main' into feature/1456-uninstall-via-windows-settings-…
hohwille May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion cli/src/main/java/com/devonfw/tools/ide/tool/IdeasyCommandlet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,7 +615,13 @@ private void deleteDownloadCache() {

private void uninstallIdeasyIdePath(Path idePath) {
if (this.context.getSystemInfo().isWindows()) {
this.context.newProcess().executable("bash").addArgs("-c",
Path bash = this.context.findBash();
if (bash == null) {
LOG.warn("Could not find bash for asynchronous deletion of {}. Falling back to direct deletion.", idePath);
this.context.getFileAccess().delete(idePath);
return;
}
this.context.newProcess().executable(bash).addArgs("-c",
"sleep 10 && rm -rf \"" + WindowsPathSyntax.MSYS.format(idePath) + "\"").run(ProcessMode.BACKGROUND);
IdeLogLevel.INTERACTION.log(LOG,
"To prevent windows file locking errors, we perform an asynchronous deletion of {} in background now.\n"
Expand Down
4 changes: 2 additions & 2 deletions windows-installer/Package.wxs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<Files Include="msi-files\**" />
<Component Id="setEnv" Directory="INSTALLFOLDER" Guid="8bea8575-87ca-4847-8b8b-202b6e34901e">
<CreateFolder/>
<Environment Id="IdeRoot" Name="IDE_ROOT" Value="[IDE_ROOT]" Permanent="yes" Action="set" System="no" />
<Environment Id="IdeRoot" Name="IDE_ROOT" Value="[IDE_ROOT]" Permanent="no" Action="set" System="no" />
</Component>
</Feature>

Expand Down Expand Up @@ -51,7 +51,7 @@
<!-- Execution of uninstall command-->
<SetProperty
Id="RunUninstallAction"
Value='"[%SystemFolder]cmd.exe" /c "[%IDE_ROOT]\_ide\installation\bin\ideasy.exe -ft --no-colors uninstall > [%IDE_ROOT]\uninstall.log 2>&amp;1"'
Value='"[%SystemFolder]cmd.exe" /v:on /c "cd /d &quot;[INSTALLFOLDER]&quot; &amp;&amp; (if not exist &quot;[%USERPROFILE]\.ide\logs&quot; mkdir &quot;[%USERPROFILE]\.ide\logs&quot;) &amp;&amp; set ts=%date:/=-%_%time::=-% &amp;&amp; set ts=!ts:,=-! &amp;&amp; bin\ideasy.exe -ft --no-colors uninstall &gt; &quot;[%USERPROFILE]\.ide\logs\uninstall-!ts!.log&quot; 2&gt;&amp;1"'
Before="RunUninstallAction"
Sequence="execute"
/>
Expand Down
Loading