#1456 : Fix uninstall via windows settings bug#1865
#1456 : Fix uninstall via windows settings bug#1865KarimALotfy wants to merge 9 commits intodevonfw:mainfrom
Conversation
Changed the uninstall command to run from the correct directory ([%IDE_ROOT]\_ide\installation) and added proper logging. Also set IDE_ROOT environment variable to be removed on uninstall.
Coverage Report for CI Build 25330206019Coverage increased (+0.02%) to 70.662%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions5 previously-covered lines in 1 file lost coverage.
Coverage Stats💛 - Coveralls |
hohwille
left a comment
There was a problem hiding this comment.
@KarimALotfy thanks for your PR. You properly analysed and fixed the problem. 👍
Indeed on Windows the bash is typically not on the PATH variable and that could have caused the error.
Also you now follow the same approach as we do in the install step and this makes it also more robust.
E.g. if the user manually deleted the log directory this would have caused the uninstall to fail.
Could you please add the issue to our CHANGELOG for the currently release (see DoD)?
BTW: since we are using single quotes to embed the script logic into XML you do not have to escape double quotes with ". However, nothing is wrong with that. This escaping only makes it even uglier to read - stupid idea actually to use XML syntax for such things since this && encoded as && cannot be prevented and all this makes it hard to maintain. I guess you already had your personal fun editing this file and testing the results.
Great job that you made it!
This PR fixes the Windows uninstall flow for IDEasy when uninstalling from Apps/Installed apps.
This PR fixes #1456
Implemented changes:
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal