Skip to content

#1456 : Fix uninstall via windows settings bug#1865

Open
KarimALotfy wants to merge 9 commits intodevonfw:mainfrom
KarimALotfy:feature/1456-uninstall-via-windows-settings-not-working
Open

#1456 : Fix uninstall via windows settings bug#1865
KarimALotfy wants to merge 9 commits intodevonfw:mainfrom
KarimALotfy:feature/1456-uninstall-via-windows-settings-not-working

Conversation

@KarimALotfy
Copy link
Copy Markdown

@KarimALotfy KarimALotfy commented Apr 28, 2026

This PR fixes the Windows uninstall flow for IDEasy when uninstalling from Apps/Installed apps.

This PR fixes #1456

Implemented changes:

  • The MSI uninstall action now runs from the installed folder and logs correctly, and the CLI uninstall no longer fails when cleaning up on Windows because it now uses the actual bash.exe path instead of the bare bash command. This resolved a failure during uninstall from Apps.

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

@github-project-automation github-project-automation Bot moved this to 🆕 New in IDEasy board Apr 28, 2026
@KarimALotfy KarimALotfy changed the title Feature/1456 uninstall via windows settings not working #1456 : Fix uninstall via windows settings bug Apr 28, 2026
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Apr 28, 2026

Coverage Report for CI Build 25330206019

Coverage increased (+0.02%) to 70.662%

Details

  • Coverage increased (+0.02%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 5 coverage regressions across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

5 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/tool/IdeasyCommandlet.java 5 72.32%

Coverage Stats

Coverage Status
Relevant Lines: 15353
Covered Lines: 11306
Line Coverage: 73.64%
Relevant Branches: 6850
Covered Branches: 4383
Branch Coverage: 63.99%
Branches in Coverage %: Yes
Coverage Strength: 3.11 hits per line

💛 - Coveralls

@KarimALotfy KarimALotfy moved this from 🆕 New to Team Review in IDEasy board Apr 28, 2026
@KarimALotfy KarimALotfy self-assigned this Apr 28, 2026
Copy link
Copy Markdown
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KarimALotfy thanks for your PR. You properly analysed and fixed the problem. 👍
Indeed on Windows the bash is typically not on the PATH variable and that could have caused the error.
Also you now follow the same approach as we do in the install step and this makes it also more robust.
E.g. if the user manually deleted the log directory this would have caused the uninstall to fail.

Could you please add the issue to our CHANGELOG for the currently release (see DoD)?

BTW: since we are using single quotes to embed the script logic into XML you do not have to escape double quotes with ". However, nothing is wrong with that. This escaping only makes it even uglier to read - stupid idea actually to use XML syntax for such things since this && encoded as && cannot be prevented and all this makes it hard to maintain. I guess you already had your personal fun editing this file and testing the results.
Great job that you made it!

@github-project-automation github-project-automation Bot moved this from Team Review to 👀 In review in IDEasy board May 4, 2026
@hohwille hohwille added this to the release:2026.05.001 milestone May 4, 2026
@hohwille hohwille added windows specific for Microsoft Windows OS install installation process of IDE + tools and install commandlet bash bash, zsh, git-bash (integration, scripts) labels May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bash bash, zsh, git-bash (integration, scripts) install installation process of IDE + tools and install commandlet windows specific for Microsoft Windows OS

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

Uninstall via Windows settings not working

3 participants