Consolidate static/compliance files to single source of truth with sync script#144
Consolidate static/compliance files to single source of truth with sync script#144elifouts merged 2 commits intoaws-ready-mainfrom
Conversation
….html email Co-authored-by: grillinr <169214325+grillinr@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Consolidates duplicated compliance/deep-linking static files by treating backend/api/static/ as the source of truth and adding a sync script to mirror them into frontend/public/ for the Expo web build.
Changes:
- Add
Bash-Scripts/sync-static.shto sync shared static files from backend → frontend public. - Update
frontend/public/account-deletion.htmlto reduce drift in the support email address. - Document the workflow in
README.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
Bash-Scripts/sync-static.sh |
Adds a sync utility to copy a fixed set of static files from backend to frontend. |
frontend/public/account-deletion.html |
Updates a mailto link to match the backend copy for one section. |
README.md |
Documents the “source of truth” directory and instructs running the sync script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Run `Bash-Scripts/sync-static.sh` after editing any file in `backend/api/static/` | ||
| to keep the frontend copy in sync. |
There was a problem hiding this comment.
The README now instructs running Bash-Scripts/sync-static.sh, but earlier sections still reference ./run-front.sh, ./run-dev.sh, etc. (which actually live under Bash-Scripts/). This mixed guidance is likely to confuse contributors; consider standardizing the invocation style across the README (or add a short note explaining the expected working directory).
| # Script: sync-static.sh | ||
| # Does: Copies compliance/static files from backend/api/static (source of truth) to frontend/public. | ||
| # Run this whenever the backend static files change to keep the frontend web build in sync. | ||
| # Use: ./sync-static.sh |
There was a problem hiding this comment.
The header comment says Use: ./sync-static.sh, but the script lives under Bash-Scripts/ and the README calls it as Bash-Scripts/sync-static.sh. Update the usage line (or mention both repo-root and in-directory invocation) to avoid incorrect copy/paste.
| # Use: ./sync-static.sh | |
| # Use: Bash-Scripts/sync-static.sh (from repo root), or ./sync-static.sh (from this directory) |
| Email us at | ||
| <a href="mailto:mail@elifouts.com">mail@elifouts.com</a> with the | ||
| <a href="mailto:mail@elifouts.net">mail@elifouts.net</a> with the | ||
| subject "Account Deletion Request" and include the username and the |
There was a problem hiding this comment.
This page now uses mail@elifouts.net in the “How to request deletion” section, but there are still other mail@elifouts.com mailto links later in the same document (e.g., the footer contact + “Request account deletion” button). This leaves the page with inconsistent contact info; update the remaining occurrences (ideally in backend/api/static/account-deletion.html as the source of truth) and then re-sync to the frontend copy.
| `backend/api/static/` is the source of truth for compliance and deep-linking files | ||
| (`apple-app-site-association`, `privacy-policy.html`, `account-deletion.html`). | ||
| The same files are mirrored into `frontend/public/` for the Expo web build. |
There was a problem hiding this comment.
This section claims backend/api/static/ is the single source of truth for deep-linking/compliance files, but assetlinks.json is also duplicated (served by the backend at /.well-known/assetlinks.json and present in frontend/public/.well-known/assetlinks.json). Either include it in the “source of truth” list + sync process, or explicitly document why it’s excluded.
* AWS-ready * Update backend/api/static/account-deletion.html Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix review comments: AASA content-type, proxy header spoofing, API_BASE_URL const mutation, installer guard, docs (#143) * Initial plan * Address PR review comments: AASA content-type, proxy header security, template check, API_BASE_URL fix, docs update Co-authored-by: elifouts <116454864+elifouts@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: elifouts <116454864+elifouts@users.noreply.github.com> * Consolidate static/compliance files to single source of truth with sync script (#144) * Initial plan * Add sync-static.sh to prevent static file drift; fix account-deletion.html email Co-authored-by: grillinr <169214325+grillinr@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: grillinr <169214325+grillinr@users.noreply.github.com> * Refactor scripts and components for improved clarity and functionality; update TypeScript configurations and enhance local development experience. * Update deployment instructions and scripts for AWS EC2 native setup; change default user to ec2-user and enhance clarity in documentation. * updated scripts for aws * updated instructions fr * screw this file * fixed --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: grillinr <169214325+grillinr@users.noreply.github.com>
backend/api/static/andfrontend/public/contained duplicate copies ofapple-app-site-association,privacy-policy.html, andaccount-deletion.htmlwith no mechanism to keep them in sync — and they had already drifted (account-deletion.htmlhad diverged email addresses).Changes
Bash-Scripts/sync-static.sh— new script that copies the three shared static files frombackend/api/static/(source of truth) tofrontend/public/, reporting per-file statusfrontend/public/account-deletion.html— fixed existing drift:mail@elifouts.com→mail@elifouts.netto match the backend copyREADME.md— documentsbackend/api/static/as the source of truth and directs contributors to runsync-static.shafter editing those files🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.