Fix bash job scripts: require_command checks, curl temp file leak, batched MySQL inserts

[Copilot]

Three unresolved code review issues in the bash job scripts: missing dependency validation in health-job, a temp file leak on curl failure in fun-fact-job, and per-row MySQL connections in pricing-job.

Changes

• health-job/script.sh: Added require_command function (matching the pattern in other jobs) with checks for curl, grep, and mktemp in main().

• fun-fact-job/script.sh: Fixed temp file leak in send_slack_message — curl now uses || true with an empty response_code guard that cleans up the temp file and returns early on failure, consistent with the health-job pattern.

• pricing-job/script.sh: Replaced O(teams × items) individual mysql_query calls with a single batched invocation wrapped in a transaction:

sql_batch=""
for team_id in "${teams[@]}"; do
    for item_row in "${items[@]}"; do
        sql_batch+="INSERT INTO price(...) VALUES(...);"$'\n'
    done
done

mysql_query "START TRANSACTION;
${sql_batch}COMMIT;" || { echo 'Batch insert failed; transaction has been rolled back' >&2; return 1; }

---

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

[Copilot]

Pull request overview

This PR tightens reliability and performance of the cron-executed bash job scripts under packages/jobs/ by adding dependency validation, preventing temp file leaks on curl failures, and reducing MySQL connection overhead via batched inserts.

Changes:

• Add require_command checks in health-job for curl, grep, and mktemp.
• Ensure fun-fact-job cleans up its curl response temp file even when curl fails.
• Batch pricing-job MySQL inserts into a single transaction instead of per-row mysql_query calls.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
packages/jobs/health-job/script.sh	Adds require_command helper and validates required CLI dependencies in main().
packages/jobs/fun-fact-job/script.sh	Prevents temp file leakage on curl failure by avoiding set -e exit and cleaning up on error.
packages/jobs/pricing-job/script.sh	Switches to transactional, batched inserts to reduce per-row MySQL invocations.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Building the entire INSERT workload into sql_batch and passing it as a single mysql -e argument can hit OS ARG_MAX/"Argument list too long" limits and/or MySQL max_allowed_packet as teams/items grow, causing the job to fail before any SQL runs. Consider streaming the SQL to mysql via stdin (or a temp file) and/or chunking into smaller batches (e.g., per team or fixed-size batches) to avoid unbounded query size and quadratic string-concatenation overhead.

Suggested change

	mysql_query "START TRANSACTION;
	${sql_batch}COMMIT;" || { echo 'Batch insert failed; transaction has been rolled back' >&2; return 1; }
	{
	echo 'START TRANSACTION;'
	printf '%s' "${sql_batch}"
	echo 'COMMIT;'
	} | mysql --host="${MYSQL_HOST}" --user="${MYSQL_USER}" --password="${MYSQL_PASSWORD}" "${MYSQL_DATABASE}" \
	|| { echo 'Batch insert failed; transaction has been rolled back' >&2; return 1; }