Fix bash job scripts: require_command checks, curl temp file leak, batched MySQL inserts (#187)

* Initial plan

* Fix code review feedback: require_command checks, temp file cleanup, batch MySQL inserts

Co-authored-by: sfreeman422 <16405652+sfreeman422@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dev-chat/mocker/sessions/1c571688-b133-4945-9edc-a6d11e23df1d

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: sfreeman422 <16405652+sfreeman422@users.noreply.github.com>

Author: Copilot

packages/jobs/fun-fact-job/script.sh

@@ -337,7 +337,13 @@ send_slack_message() {
 		--header "Authorization: Bearer ${MUZZLE_BOT_TOKEN}" \
 		--header 'Content-Type: application/json; charset=utf-8' \
 		--data "${payload}" \
-		https://slack.com/api/chat.postMessage)
+		https://slack.com/api/chat.postMessage || true)
+
+	if [[ -z "${response_code:-}" ]]; then
+		echo "Slack API request failed: curl did not complete successfully" >&2
+		rm -f "${response_file}"
+		return 1
+	fi
 
 	if [[ "${response_code}" != '200' ]] || ! jq -e '.ok == true' "${response_file}" >/dev/null 2>&1; then
 		cat "${response_file}" >&2

packages/jobs/health-job/script.sh

@@ -10,6 +10,15 @@ fi
 
 PATH=/usr/local/bin:/usr/bin:/bin:${PATH:-}
 
+require_command() {
+	local command_name="$1"
+
+	if ! command -v "${command_name}" >/dev/null 2>&1; then
+		echo "Missing required command: ${command_name}" >&2
+		exit 1
+	fi
+}
+
 HEALTH_URL="${HEALTH_URL:-http://127.0.0.1:3000/health}"
 SLACK_CHANNEL="${SLACK_CHANNEL:-#muzzlefeedback}"
 SLACK_MESSAGE=':this-is-fine: `Moonbeam is experiencing some technical difficulties at the moment.` :this-is-fine:'
@@ -89,6 +98,10 @@ check_health() {
 }
 
 main() {
+	require_command curl
+	require_command grep
+	require_command mktemp
+
 	if check_health; then
 		exit 0
 	fi

packages/jobs/pricing-job/script.sh

@@ -96,6 +96,7 @@ main() {
 	local price_pct
 	local price
 	local median_rep
+	local sql_batch
 	local -a teams
 	local -a items
 	local row
@@ -125,18 +126,25 @@ main() {
 
 	median_rep=$(calculate_median_rep)
 
+	sql_batch=""
 	for team_id in "${teams[@]}"; do
 		[[ -n "${team_id}" ]] || continue
 
 		for item_row in "${items[@]}"; do
 			IFS=$'\t' read -r item_id price_pct <<<"${item_row}"
 			price=$(awk -v median="${median_rep}" -v pct="${price_pct}" 'BEGIN { printf "%.15f", median * pct }')
-			mysql_query "INSERT INTO price(itemId, teamId, price, itemIdId) VALUES(${item_id}, '$(sql_escape "${team_id}")', ${price}, ${item_id});" >/dev/null
+			sql_batch+="INSERT INTO price(itemId, teamId, price, itemIdId) VALUES(${item_id}, '$(sql_escape "${team_id}")', ${price}, ${item_id});"$'\n'
 		done
 
-		echo "Completed update for ${team_id}"
+		echo "Queued update for ${team_id}"
 	done
 
+	if [[ -n "${sql_batch}" ]]; then
+		echo 'Executing batch price inserts...'
+		mysql_query "START TRANSACTION;
+${sql_batch}COMMIT;" || { echo 'Batch insert failed; transaction has been rolled back' >&2; return 1; }
+	fi
+
 	echo "Completed job in $(( $(date +%s) - start_time )) seconds!"
 }