-
Notifications
You must be signed in to change notification settings - Fork 535
dbeaver/pro#9526 adds profile form #4390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sergeyteleshev
wants to merge
17
commits into
devel
Choose a base branch
from
9526-cb-add-profiles-to-project-form
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+784
−336
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
cd8a285
dbeaver/pro#9526 adds profile form base functionality
sergeyteleshev 71ef310
Merge branch 'devel' into 9526-cb-add-profiles-to-project-form
sergeyteleshev 1e618b1
Merge branch 'devel' into 9526-cb-add-profiles-to-project-form
sergeyteleshev 3277a78
dbeaver/pro#9526 adds profiles form
sergeyteleshev 2257341
dbeaver/pro#9526 moves SSHForm to connection-network-handlers to reus…
sergeyteleshev bad0024
dbeaver/pro#9526 moves ssh files to connection-network-handlers-plugin
sergeyteleshev 50602a0
Merge branch 'devel' into 9526-cb-add-profiles-to-project-form
sergeyteleshev 8df9e2b
pr fixes
sergeyteleshev 66e0bde
moves enable form switch inside SSHForm
sergeyteleshev 3103d99
dbeaver/pro#9526 shares the rest logic for configuring the ssh with p…
sergeyteleshev c046a95
dbeaver/pro#9526 cleanup
sergeyteleshev 0d17c7f
dbeaver/pro#9526 adds go back to profiles arrow action
sergeyteleshev 38943a3
dbeaver/pro#9526 small ui adjustments
sergeyteleshev cdf4232
dbeaver/pro#9618 pr fixes
sergeyteleshev 5d1361a
Merge branch 'devel' into 9526-cb-add-profiles-to-project-form
sergeyteleshev 0f6e798
Merge branch 'devel' into 9526-cb-add-profiles-to-project-form
sergeyteleshev 2ec2be5
dbeaver/pro#9526 creates ProjectInfoOptionsPanelService to incapsulat…
sergeyteleshev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,6 +14,10 @@ | |
| overflow: auto; | ||
| } | ||
|
|
||
| &[data-s-gap='xxs'] { | ||
| gap: 4px; | ||
| } | ||
|
|
||
| &[data-s-gap='xs'] { | ||
| gap: 8px; | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 47 additions & 0 deletions
47
webapp/packages/plugin-connection-network-handlers/package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| { | ||
| "name": "@cloudbeaver/plugin-connection-network-handlers", | ||
| "type": "module", | ||
| "sideEffects": [ | ||
| "./lib/module.js", | ||
| "./lib/index.js", | ||
| "src/**/*.css", | ||
| "public/**/*" | ||
| ], | ||
| "version": "0.1.0", | ||
| "description": "", | ||
| "license": "Apache-2.0", | ||
| "exports": { | ||
| ".": "./lib/index.js", | ||
| "./module": "./lib/module.js" | ||
| }, | ||
| "scripts": { | ||
| "build": "tsc -b", | ||
| "clean": "rimraf --glob lib", | ||
| "lint": "eslint ./src/ --ext .ts,.tsx", | ||
| "test": "dbeaver-test", | ||
| "validate-dependencies": "core-cli-validate-dependencies" | ||
| }, | ||
| "dependencies": { | ||
| "@cloudbeaver/core-blocks": "workspace:*", | ||
| "@cloudbeaver/core-connections": "workspace:*", | ||
| "@cloudbeaver/core-di": "workspace:*", | ||
| "@cloudbeaver/core-localization": "workspace:*", | ||
| "@cloudbeaver/core-projects": "workspace:*", | ||
| "@cloudbeaver/core-root": "workspace:*", | ||
| "@cloudbeaver/core-sdk": "workspace:*", | ||
| "@cloudbeaver/core-utils": "workspace:*", | ||
| "mobx": "^6", | ||
| "mobx-react-lite": "^4", | ||
| "react": "^19", | ||
| "react-dom": "^19" | ||
| }, | ||
| "devDependencies": { | ||
| "@cloudbeaver/core-cli": "workspace:*", | ||
| "@cloudbeaver/tsconfig": "workspace:*", | ||
| "@dbeaver/cli": "workspace:*", | ||
| "@types/react": "^19", | ||
| "rimraf": "^6", | ||
| "tslib": "^2", | ||
| "typescript": "^5" | ||
| } | ||
| } |
39 changes: 39 additions & 0 deletions
39
webapp/packages/plugin-connection-network-handlers/src/LocaleService.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| /* | ||
| * CloudBeaver - Cloud Database Manager | ||
| * Copyright (C) 2020-2026 DBeaver Corp and others | ||
| * | ||
| * Licensed under the Apache License, Version 2.0. | ||
| * you may not use this file except in compliance with the License. | ||
| */ | ||
| import { Bootstrap, injectable } from '@cloudbeaver/core-di'; | ||
| import { LocalizationService } from '@cloudbeaver/core-localization'; | ||
|
|
||
| @injectable(() => [LocalizationService]) | ||
| export class LocaleService extends Bootstrap { | ||
| constructor(private readonly localizationService: LocalizationService) { | ||
| super(); | ||
| } | ||
|
|
||
| override register(): void { | ||
| this.localizationService.addProvider(this.provider.bind(this)); | ||
| } | ||
|
|
||
| private async provider(locale: string) { | ||
| switch (locale) { | ||
| case 'ru': | ||
| return (await import('./locales/ru.js')).default; | ||
| case 'de': | ||
| return (await import('./locales/de.js')).default; | ||
| case 'it': | ||
| return (await import('./locales/it.js')).default; | ||
| case 'zh': | ||
| return (await import('./locales/zh.js')).default; | ||
| case 'fr': | ||
| return (await import('./locales/fr.js')).default; | ||
| case 'vi': | ||
| return (await import('./locales/vi.js')).default; | ||
| default: | ||
| return (await import('./locales/en.js')).default; | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need to change it through the whole app?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think we should, just apply speciifc style on the GroupBack level, no need to declare new style on the whole app level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets not be afraid of changes here, please.I simply removed 4 pixels all over the forms for navigation arrow
we should not be paranoid about every change. just look at the screenshots, it became a bit prettier, isn't it great? previously spacing is kinda gigantic
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its not about changing gap pixels, its about adding xxs variant, like we already have xs. We only need the xss here, in group back, so its better to adjust gap only here. Also all visual tests will fail and we need to update them because of that, this also a reason. If you insist, we can keep it