dbeaver/pro#9526 adds profile form by sergeyteleshev · Pull Request #4390 · dbeaver/cloudbeaver

sergeyteleshev · 2026-06-09T22:29:48Z

closes https://github.com/dbeaver/pro/issues/9526

codacy-production · 2026-06-09T22:30:47Z

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 67 complexity

Metric Results

Complexity 67

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes.}

…e it for admin settings in future without extra deps

devnaumov · 2026-06-13T10:02:49Z

+import { Bootstrap, injectable } from '@cloudbeaver/core-di';
+
+@injectable()
+export class PluginConnectionNetworkHandlersBootstrap extends Bootstrap {


…rofiles form as well

Copilot

Pull request overview

This PR introduces a new @cloudbeaver/plugin-connection-network-handlers package to centralize SSH network handler UI/logic and wires it into the common plugin set and connection forms. It also adds support for opening the Project Info form with a preselected tab and extends the Flex component with an extra-small gap option.

Changes:

Added new plugin-connection-network-handlers package (SSH form, helpers, validation, localization, module bootstrap).
Refactored existing SSH UI/logic in plugin-connections to reuse the new package and moved SSH-related i18n strings out of core-connections.
Enhanced Project Info form to accept a default selected tab; added xxs gap support in core-blocks/Flex.

Reviewed changes

Copilot reviewed 42 out of 43 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
webapp/yarn.lock	Adds workspace resolution and dependencies for the new plugin package.
webapp/packages/plugin-set-common/tsconfig.json	Adds TS project reference for the new plugin.
webapp/packages/plugin-set-common/src/index.ts	Registers the new plugin module in the common plugin set.
webapp/packages/plugin-set-common/package.json	Adds dependency on `@cloudbeaver/plugin-connection-network-handlers`.
webapp/packages/plugin-project-info/tsconfig.json	Adjusts TS include patterns (drops scss).
webapp/packages/plugin-project-info/src/ProjectInfoForm/ProjectInfoFormService.ts	Adds default tab selection support when opening Project Info form.
webapp/packages/plugin-project-info/src/ProjectInfoForm/ProjectInfoFormPanel.tsx	Passes selected tab id into `TabsState`.
webapp/packages/plugin-project-info/package.json	Removes scss from sideEffects list.
webapp/packages/plugin-connections/tsconfig.json	Adds TS project reference for the new plugin.
webapp/packages/plugin-connections/src/index.ts	Exposes additional exports including network handler config types.
webapp/packages/plugin-connections/src/ConnectionForm/SSH/SSH.tsx	Replaces inline SSH UI with `SSHForm` from the new plugin.
webapp/packages/plugin-connections/src/ConnectionForm/SSH/ConnectionFormSSHPart.ts	Moves SSH defaults/config/validation to the new plugin helpers.
webapp/packages/plugin-connections/src/ConnectionAuthentication/NetworkHandlerAuthForm.tsx	Reuses `SSHKeyUploader` from the new plugin.
webapp/packages/plugin-connections/package.json	Adds dependency on `@cloudbeaver/plugin-connection-network-handlers`.
webapp/packages/plugin-connection-network-handlers/tsconfig.json	New package TS build configuration.
webapp/packages/plugin-connection-network-handlers/src/SSH/validateSSHConfig.ts	New shared SSH validation helper.
webapp/packages/plugin-connection-network-handlers/src/SSH/SSHKeyUploader.tsx	Updates SSH key uploader to use plugin-scoped i18n keys.
webapp/packages/plugin-connection-network-handlers/src/SSH/sshHelpers.ts	New shared SSH defaults/config building + trimming.
webapp/packages/plugin-connection-network-handlers/src/SSH/SSHForm.tsx	New shared SSH form UI component.
webapp/packages/plugin-connection-network-handlers/src/SSH/sshAuthTypes.ts	Renames/exports SSH auth type list for reuse.
webapp/packages/plugin-connection-network-handlers/src/SSH/getNetworkHandlerDefaultProperties.ts	New helper for non-secured default properties.
webapp/packages/plugin-connection-network-handlers/src/module.ts	Registers plugin module.
webapp/packages/plugin-connection-network-handlers/src/LocaleService.ts	Adds plugin localization provider.
webapp/packages/plugin-connection-network-handlers/src/locales/zh.ts	Adds plugin SSH localization strings (ZH).
webapp/packages/plugin-connection-network-handlers/src/locales/vi.ts	Adds plugin SSH localization strings (VI).
webapp/packages/plugin-connection-network-handlers/src/locales/ru.ts	Adds plugin SSH localization strings (RU).
webapp/packages/plugin-connection-network-handlers/src/locales/it.ts	Adds plugin SSH localization strings (IT).
webapp/packages/plugin-connection-network-handlers/src/locales/fr.ts	Adds plugin SSH localization strings (FR).
webapp/packages/plugin-connection-network-handlers/src/locales/en.ts	Adds plugin SSH localization strings (EN).
webapp/packages/plugin-connection-network-handlers/src/locales/de.ts	Adds plugin SSH localization strings (DE).
webapp/packages/plugin-connection-network-handlers/src/index.ts	Exports plugin public API and ensures module bootstrap is loaded.
webapp/packages/plugin-connection-network-handlers/package.json	New package manifest, scripts, deps/exports.
webapp/packages/core-connections/src/locales/zh.ts	Removes SSH UI strings moved into the plugin (ZH).
webapp/packages/core-connections/src/locales/vi.ts	Removes SSH UI strings moved into the plugin (VI).
webapp/packages/core-connections/src/locales/ru.ts	Removes SSH UI strings moved into the plugin (RU).
webapp/packages/core-connections/src/locales/it.ts	Removes SSH UI strings moved into the plugin (IT).
webapp/packages/core-connections/src/locales/fr.ts	Removes SSH UI strings moved into the plugin (FR).
webapp/packages/core-connections/src/locales/en.ts	Removes SSH UI strings moved into the plugin (EN).
webapp/packages/core-connections/src/locales/de.ts	Removes SSH UI strings moved into the plugin (DE).
webapp/packages/core-connections/src/index.ts	Updates header year.
webapp/packages/core-blocks/src/Flex/Flex.tsx	Extends `gap` prop union to include `xxs`.
webapp/packages/core-blocks/src/Flex/Flex.module.css	Adds CSS styling for `data-s-gap='xxs'`.
webapp/packages/core-blocks/src/Containers/GroupBack.tsx	Uses the new `xxs` gap.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+    this.formState?.dispose();
+    this.formState = new FormState<IProjectInfoFormState>(this.serviceProvider, this, { projectId }).setMode(FormMode.Edit);



+  if (!state.properties?.['host']?.length) {
+    errors.push("Field SSH 'Host' can't be empty");
+  }


+  const port = Number(state.properties?.['port']);
+  if (Number.isNaN(port) || port < 1) {
+    errors.push("Field SSH 'Port' can't be empty");
+  }


SychevAndrey

Great job! 👍🏻
Maybe we could add a gap parameter to GroupBack to not touch other parts of the app?

SychevAndrey · 2026-06-16T09:22:16Z


  return (
-    <Flex gap="xs" align="center">
+    <Flex gap="xxs" align="center">


why do we need to change it through the whole app?

I dont think we should, just apply speciifc style on the GroupBack level, no need to declare new style on the whole app level

lets not be afraid of changes here, please.I simply removed 4 pixels all over the forms for navigation arrow

we should not be paranoid about every change. just look at the screenshots, it became a bit prettier, isn't it great? previously spacing is kinda gigantic

I think its not about changing gap pixels, its about adding xxs variant, like we already have xs. We only need the xss here, in group back, so its better to adjust gap only here. Also all visual tests will fail and we need to update them because of that, this also a reason. If you insist, we can keep it

devnaumov · 2026-06-17T09:35:01Z


  return (
-    <Flex gap="xs" align="center">
+    <Flex gap="xxs" align="center">


I dont think we should, just apply speciifc style on the GroupBack level, no need to declare new style on the whole app level

devnaumov · 2026-06-17T09:40:35Z

-    delete handlerConfig.secureProperties;
-
-    return handlerConfig;
+    return getSSHHandlerConfig(this.state, this.initialState, this.optionsPart.state.sharedCredentials);


please dont move method's logic to separate functions unless you have several places where you will reuse them

We have 2 places where we use it. Thats why I moved some common logic between connection crete/edit SSH part and profile SSH part so I can reuse it

devnaumov · 2026-06-17T09:41:30Z

-
-    if (!keyAuth && this.state.savePassword && !passwordSaved && !this.state.password?.length) {
-      validation.error("Field SSH 'Password' can't be empty");
+    for (const error of validateSSHConfig(this.state, this.initialState)) {


the same, why did you create a separate function for this? seems like its only used here

it is also reused. we need to validate config in 2 forms the same way

devnaumov · 2026-06-17T09:42:09Z

-    active: selected,
-  });
+
  const SSHPart = getConnectionFormSSHPart(formState);


no biggie but alright

devnaumov · 2026-06-17T09:46:29Z

 @injectable(() => [LocalizationService, NotificationService, OptionsPanelService, IServiceProvider])
 export class ProjectInfoFormService extends FormBaseService<IProjectInfoFormState> {
  formState: FormState<IProjectInfoFormState> | null;
+  defaultSelectedId: string | undefined;


This seems strange, please refer to the UserProfileOptionsPanelService where we open panel with predefined tabId like this, UserProfileOptionsPanelService.open(SETTINGS_TAB_ID), in general defaultSelectedId should not be stored here, only to be passed when opening.

this is pretty much similar mechanism but more incapsulated and reuses existing code. look prettier now, thanks

2ec2be5

devnaumov · 2026-06-17T09:48:06Z

+import { NetworkHandlerAuthType, type NetworkHandlerConfigInput } from '@cloudbeaver/core-sdk';
+import { toJS } from 'mobx';
+
+export const SSH_DEFAULT_HANDLER_CONFIG: () => NetworkHandlerConfigInput = () => ({


i dont think we need this new file

we definitely need this new file to reuse shared logic between 2 very similar parts which works with the same entity - SSH CONFIG

it allows to reuse common code between 2 parts of the app without repeating it again and again

i can like maybe restructure it, it seems a bit messy after refactoring I agree. but shared logic is wether good than not

…e opening logic with tabId

dbeaver/pro#9526 adds profile form base functionality

cd8a285

sergeyteleshev self-assigned this Jun 9, 2026

sergeyteleshev added 5 commits June 11, 2026 16:56

Merge branch 'devel' into 9526-cb-add-profiles-to-project-form

71ef310

Merge branch 'devel' into 9526-cb-add-profiles-to-project-form

1e618b1

dbeaver/pro#9526 adds profiles form

3277a78

dbeaver/pro#9526 moves SSHForm to connection-network-handlers to reus…

2257341

…e it for admin settings in future without extra deps

dbeaver/pro#9526 moves ssh files to connection-network-handlers-plugin

bad0024

sergeyteleshev marked this pull request as ready for review June 12, 2026 22:40

sergeyteleshev requested review from SychevAndrey and devnaumov June 12, 2026 22:40

devnaumov reviewed Jun 13, 2026

View reviewed changes

sergeyteleshev added 7 commits June 14, 2026 14:12

Merge branch 'devel' into 9526-cb-add-profiles-to-project-form

50602a0

pr fixes

8df9e2b

moves enable form switch inside SSHForm

66e0bde

dbeaver/pro#9526 shares the rest logic for configuring the ssh with p…

3103d99

…rofiles form as well

dbeaver/pro#9526 cleanup

c046a95

dbeaver/pro#9526 adds go back to profiles arrow action

0d17c7f

dbeaver/pro#9526 small ui adjustments

38943a3

SychevAndrey requested a review from Copilot June 16, 2026 09:15

Copilot started reviewing on behalf of SychevAndrey June 16, 2026 09:15 View session

Copilot AI reviewed Jun 16, 2026

View reviewed changes

SychevAndrey previously approved these changes Jun 16, 2026

View reviewed changes

dbeaver/pro#9618 pr fixes

cdf4232

sergeyteleshev dismissed SychevAndrey’s stale review via cdf4232 June 16, 2026 11:42

Merge branch 'devel' into 9526-cb-add-profiles-to-project-form

5d1361a

devnaumov reviewed Jun 17, 2026

View reviewed changes

sergeyteleshev added 2 commits June 17, 2026 13:15

Merge branch 'devel' into 9526-cb-add-profiles-to-project-form

0f6e798

dbeaver/pro#9526 creates ProjectInfoOptionsPanelService to incapsulat…

2ec2be5

…e opening logic with tabId

sergeyteleshev requested a review from devnaumov June 17, 2026 12:23

sergeyteleshev requested a review from SychevAndrey June 17, 2026 12:23

		this.formState?.dispose();
		this.formState = new FormState<IProjectInfoFormState>(this.serviceProvider, this, { projectId }).setMode(FormMode.Edit);

Conversation

sergeyteleshev commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codacy-production Bot commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Up to standards ✅

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

SychevAndrey left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

devnaumov Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sergeyteleshev Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sergeyteleshev commented Jun 9, 2026 •

edited

Loading

codacy-production Bot commented Jun 9, 2026 •

edited

Loading

devnaumov Jun 17, 2026 •

edited

Loading

sergeyteleshev Jun 17, 2026 •

edited

Loading