Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -206,12 +206,25 @@ private void configureCloudSqlProperties(HikariConfig config, String jdbcUrl) {

config.addDataSourceProperty("socketFactory", "com.google.cloud.sql.postgres.SocketFactory");
config.addDataSourceProperty("unixSocketPath", instanceUnixSocket);
String cloudSqlInstance = extractCloudSqlInstance(instanceUnixSocket);
if (isNotBlank(cloudSqlInstance)) {
config.addDataSourceProperty("cloudSqlInstance", cloudSqlInstance);
}

if (isCloudRun()) {
config.addDataSourceProperty("cloudSqlRefreshStrategy", "lazy");
}
}

private String extractCloudSqlInstance(String unixSocketPath) {
final String prefix = "/cloudsql/";
if (!isNotBlank(unixSocketPath) || !unixSocketPath.startsWith(prefix)) {
return null;
}
String instanceConnectionName = unixSocketPath.substring(prefix.length());
return isNotBlank(instanceConnectionName) ? instanceConnectionName : null;
}

private String extractUnixSocketPath(String jdbcUrl) {
String rawQuery = extractRawQuery(jdbcUrl);
if (!isNotBlank(rawQuery)) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ void hikariConfig_ShouldNormalizeCloudSqlSocketStyleDatabaseUrl() throws Excepti
assertThat(result.getDataSourceProperties())
.containsEntry("socketFactory", "com.google.cloud.sql.postgres.SocketFactory")
.containsEntry("unixSocketPath", "/cloudsql/project-id:region:instance-id")
.containsEntry("cloudSqlInstance", "project-id:region:instance-id")
.doesNotContainKey("cloudSqlRefreshStrategy");
}

Expand All @@ -120,6 +121,7 @@ void hikariConfig_ShouldSetCloudSqlRefreshStrategyOnCloudRunInSocketMode() throw
assertThat(result.getDataSourceProperties())
.containsEntry("socketFactory", "com.google.cloud.sql.postgres.SocketFactory")
.containsEntry("unixSocketPath", "/cloudsql/project-id:region:instance-id")
.containsEntry("cloudSqlInstance", "project-id:region:instance-id")
.containsEntry("cloudSqlRefreshStrategy", "lazy");
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,13 +76,22 @@ object DatabaseFactory {

hikariConfig.addDataSourceProperty("socketFactory", CLOUD_SQL_SOCKET_FACTORY)
hikariConfig.addDataSourceProperty("unixSocketPath", config.host)
val cloudSqlInstance = extractCloudSqlInstance(config.host)
if (cloudSqlInstance != null) {
hikariConfig.addDataSourceProperty("cloudSqlInstance", cloudSqlInstance)
}

val cloudRunService = System.getenv("K_SERVICE")
val cloudRunRevision = System.getenv("K_REVISION")
if (!cloudRunService.isNullOrBlank() || !cloudRunRevision.isNullOrBlank()) {
hikariConfig.addDataSourceProperty("cloudSqlRefreshStrategy", "lazy")
}
}

private fun extractCloudSqlInstance(unixSocketPath: String): String? {
val instance = unixSocketPath.removePrefix(CLOUD_SQL_PATH_PREFIX)
return instance.takeIf { it.isNotBlank() }
}
}

/**
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package com.lampcontrol.database

import com.zaxxer.hikari.HikariConfig
import org.junit.jupiter.api.Test
import kotlin.test.assertEquals
import kotlin.test.assertNotNull

class DatabaseFactoryTest {
Expand Down Expand Up @@ -32,4 +34,44 @@ class DatabaseFactoryTest {
// Verify DatabaseFactory object can be accessed
assertNotNull(DatabaseFactory)
}

@Test
fun `configureCloudSqlProperties sets cloudSqlInstance from unix socket path`() {
val hikariConfig = HikariConfig()
val config =
DatabaseConfig(
host = "/cloudsql/project:region:instance-id",
port = 5432,
database = "lamp-control",
user = "postgres",
password = "secret",
poolMin = 0,
poolMax = 4,
maxLifetimeMs = 3600000,
idleTimeoutMs = 1800000,
connectionTimeoutMs = 30000,
)

val configureMethod =
DatabaseFactory::class.java.getDeclaredMethod(
"configureCloudSqlProperties",
HikariConfig::class.java,
DatabaseConfig::class.java,
)
configureMethod.isAccessible = true
configureMethod.invoke(DatabaseFactory, hikariConfig, config)

assertEquals(
"com.google.cloud.sql.postgres.SocketFactory",
hikariConfig.dataSourceProperties["socketFactory"],
)
assertEquals(
"/cloudsql/project:region:instance-id",
hikariConfig.dataSourceProperties["unixSocketPath"],
)
assertEquals(
"project:region:instance-id",
hikariConfig.dataSourceProperties["cloudSqlInstance"],
)
}
}