Add cloudSqlInstance extraction for PostgreSQL sockets#401
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for extracting and setting the cloudSqlInstance property from Unix socket paths for Google Cloud SQL connections in both Java and Kotlin implementations. This ensures proper JDBC configuration when connecting to Cloud SQL using Unix domain sockets.
Changes:
- Added
extractCloudSqlInstancehelper methods in both Java and Kotlin to parse the instance connection name from Unix socket paths - Updated
configureCloudSqlPropertiesmethods to set thecloudSqlInstancedatasource property - Added comprehensive tests verifying the new property is correctly set alongside existing Cloud SQL configuration
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/java/src/main/java/org/openapitools/config/DataSourceConfig.java | Added extractCloudSqlInstance method to extract instance name from Unix socket path and set cloudSqlInstance property |
| src/java/src/test/java/org/openapitools/config/DataSourceConfigTest.java | Updated existing tests to verify cloudSqlInstance property is set correctly |
| src/kotlin/src/main/kotlin/com/lampcontrol/database/DatabaseFactory.kt | Added extractCloudSqlInstance method to extract instance name from Unix socket path and set cloudSqlInstance property |
| src/kotlin/src/test/kotlin/com/lampcontrol/database/DatabaseFactoryTest.kt | Added new test to verify cloudSqlInstance property extraction and configuration |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cloudSqlInstancewhen a unix socket path is provided for both Java and Kotlin datasourcesTesting