Skip to content

Fix incorrect test selection when -update if present #4174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
denik merged 1 commit into from
Dec 29, 2025
+0 −10
Merged

Fix incorrect test selection when -update if present #4174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions acceptance/acceptance_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,16 +333,6 @@ func testAccept(t *testing.T, inprocessMode bool, singleTest string) int {

expanded := internal.ExpandEnvMatrix(config.EnvMatrix)

if testdiff.OverwriteMode && len(expanded) > 1 {
// All variants of the test are producing the same output,
// there is no need to run the concurrently when updating.
// Exception: if EnvVaryOutput is configured, we must
// run all variants to record variant-specific outputs.
if config.EnvVaryOutput == nil || len(config.EnvMatrix[*config.EnvVaryOutput]) <= 1 {
expanded = expanded[0:1]
}
}

if len(expanded) == 1 {
// env vars aren't part of the test case name, so log them for debugging
if len(expanded[0]) > 0 {
Expand Down