Fix incorrect test selection when -update if present #4174
Merged
+0
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If -update flag is present, the test runner does not select the right subtest but picks the first one always. This made sense when all subtests were expected to generate the same output but that's not the case anymore. There is attempt to fix it by checking EnvVaryOutput but that just makes it more confusing. Also, when debugging a test, it could be useful to record output of specific subtest as a comparison base.
denik
requested review from
andrewnester,
anton-107,
pietern and
shreyas-goenka
as code owners
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 5d8d3a9
19 interesting tests: 18 KNOWN, 1 SKIP
Top 23 slowest tests (at least 2 minutes):
|
shreyas-goenka
approved these changes
Dec 29, 2025
Collaborator
|
Commit: bb774b8
35 interesting tests: 14 KNOWN, 8 flaky, 7 FAIL, 4 RECOVERED, 1 SKIP, 1 MISS
Top 50 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
If -update flag is present, the test runner does not select the right subtest but picks the first one always. This made sense when all subtests were expected to generate the same output but that's not the case anymore. There is attempt to fix it by checking EnvVaryOutput but that just makes it more confusing.
When debugging a test, it is sometimes useful to record output of specific subtest as a comparison base.