Add interactive warehouse picker for templates that make use of SQL warehouses #4170
+242
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `SelectWarehouse` function with state-sorted picker (running first) - Add `GetDefaultWarehouse` function for determining default warehouse - Add `Format` field to JSON schema for custom input types - Use `format: "warehouse_path"` in default-sql and dbt-sql templates - Update apps-mcp to use shared `GetDefaultWarehouse` logic - Fix case-insensitive search in cmdio Select 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add filter support to SelectWarehouse (variadic warehouseFilter) - Show warehouse type (pro/classic/serverless) in gray lowercase - Make [DEFAULT] marker gray - Sort by state priority then alphabetically for default selection - Display list sorted by running state first, then alphabetically 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
lennartkats-db
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
lennartkats-db
commented
Dec 23, 2025
| } | ||
| return cmdio.Select(ctx, names, "Choose SQL Warehouse") | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
N.B., the logic for detecting warehouses is what we discussed with the DBSQL org and follows what's already in the apps-mcp experimental code.
1 task
Collaborator
|
Commit: 9e3669f
19 interesting tests: 18 KNOWN, 1 SKIP
Top 24 slowest tests (at least 2 minutes):
|
andrewnester
approved these changes
Dec 29, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 31, 2025
## Summary Refactors apps-mcp warehouse selection to use the shared `cfgpickers.GetDefaultWarehouse` function from #4170. - [x] This is a PR stacked on top of the above PR; it needs to be changed to target `main` before merging --------- Co-authored-by: Claude <noreply@anthropic.com>
Collaborator
|
Commit: e0f32d7
31 interesting tests: 18 KNOWN, 6 FAIL, 6 flaky, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds an interactive warehouse picker + default warehouse support for templates that make use of a warehouse option:
Note that this PR doesn't change the interface of existing templates: we keep using
http_pathas the property name for warehouses to maintain compatibility in the workspace and any client tools that depend on that name. The property just has a new"format": "warehouse_path"setting that describes the new behavior.Test plan
make lintandmake fmtpassdatabricks bundle initwith SQL templates