Refactor apps-mcp to use shared GetDefaultWarehouse #4171
Merged
+7
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `SelectWarehouse` function with state-sorted picker (running first) - Add `GetDefaultWarehouse` function for determining default warehouse - Add `Format` field to JSON schema for custom input types - Use `format: "warehouse_path"` in default-sql and dbt-sql templates - Update apps-mcp to use shared `GetDefaultWarehouse` logic - Fix case-insensitive search in cmdio Select 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add filter support to SelectWarehouse (variadic warehouseFilter) - Show warehouse type (pro/classic/serverless) in gray lowercase - Make [DEFAULT] marker gray - Sort by state priority then alphabetically for default selection - Display list sorted by running state first, then alphabetically 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This reverts commit 5bc507d.
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
igrekun
approved these changes
Dec 26, 2025
lennartkats-db
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: de47c12
25 interesting tests: 18 KNOWN, 4 flaky, 2 FAIL, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors apps-mcp warehouse selection to use the shared
cfgpickers.GetDefaultWarehousefunction from #4170.mainbefore merging