chore: retire upstream-sync cron, sync manifest to 2.1.161#40
Merged
Conversation
The daily upstream-sync GitHub Action could only bump a version number and dump the drift string into a PR body — it never read the changelog, so it was blind to new features, settings keys, env vars, hook events, and dedupe opportunities (its diffSets compares the manifest against our own zod schema, not upstream). That triage is the human /cc sync skill's job; the bot's PRs looked actionable but weren't and raced the manual flow. Making it smarter would have meant a standing ANTHROPIC_API_KEY/OAuth token in CI secrets, billed unattended on every release. Removed: the workflow, the --open-pr path + openSyncPr/saveManifest in scan.ts (now a pure dry-run detector), and stale 'daily GH Action'/'bot owns this file' references across the manifest, skill, schema, and CI comment. Kept: bun run upstream:scan (dry-run detector) + its non-gating CI job. Also syncs the manifest to Claude Code 2.1.161 (otherwise all bug fixes; adds CLAUDE_CODE_TMPDIR to knownEnvVars + the env-var table; OTEL_RESOURCE_ATTRIBUTES skipped as a generic OTEL var).
4 tasks
arzafran
added a commit
that referenced
this pull request
Jun 3, 2026
Versions work that had accumulated in [Unreleased] without a bump: team-knowledge repo migration (#38), nuclear-review maintainability pass, upstream-sync cron retirement + CC 2.1.161 sync (#40), dynamic-workflow guidance + dead-telemetry removal (#41), docs accuracy pass + USAGE.md removal (#42). VERSION 11.16.0 → 11.17.0; CHANGELOG [Unreleased] promoted to [11.17.0].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces #39 (closed). The daily upstream-sync cron is retired in favor of the manual
/cc syncskill.Why: the bot could only ever bump a version number and dump the drift string into a PR body. Its
diffSetscompares the manifest against cc-settings' own zod schema — never upstream — and it never fetched the changelog, so it was structurally blind to new features, settings keys, env vars, hook events, and dedupe opportunities. That triage is the human skill's job. The bot's PRs looked actionable but weren't, and raced the manual flow (#39 had already bumped the manifest while a manual sync was mid-flight). Making the cron smarter would have required a standingANTHROPIC_API_KEY/OAuth token in repo secrets, burned unattended on every release.Removed
.github/workflows/upstream-sync.yml(the cron)openSyncPr/saveManifest/ the--open-prbranch insrc/upstream/scan.ts— now a pure dry-run detector (nowriteFile/runProcessFullimports)description/source,skills/cc/SKILL.md,src/schemas/skill.ts, and theci.ymlupstream-scancommentKept
bun run upstream:scan— the dry-run detector, now the manual way to spot drift before running/cc syncupstream-scanCI job (surfaces drift in PR logs)Also: upstream sync to Claude Code 2.1.161
Manifest
2.1.160→2.1.161. Release is otherwise all bug fixes / UI / perf with no cc-settings surface. One tracked addition:CLAUDE_CODE_TMPDIR(surfaced by theEADDRINUSE/Unix-socket fix) →knownEnvVars+ env-var table.OTEL_RESOURCE_ATTRIBUTESskipped (generic OTEL SDK var, outside our CC-specific convention).Test Plan
bun run typecheckcleanbun test— 467 pass, 0 failbun run lintcleanbun run lint:skills— 0 errors/warningsbun run upstream:scan— no drift detected at 2.1.161