Skip to content

configurables ui#229

Closed
cooper (czxtm) wants to merge 2 commits into
graphite-base/229from
cm/derive-config-ui
Closed

configurables ui#229
cooper (czxtm) wants to merge 2 commits into
graphite-base/229from
cm/derive-config-ui

Conversation

@czxtm
Copy link
Copy Markdown
Member

Summary

Test Plan

Docs

  • Docs updated (companion PR in darkmatter/nixmac-web: #___)
  • No docs update needed

cooper (czxtm) and others added 2 commits May 28, 2026 15:12
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The Tuning section is a new home for behavior knobs that grow over time as
more Configurable structs are migrated. Starts with the same two settings
(max iterations, max build attempts) that were previously hidden inside
the AI Models tab — moved here because they're not about models.

The Backup & Restore section adds:
  - Export settings.json — opens a save dialog and writes a filtered copy
    of the plugin-store. By default legacy plain-text API keys
    (openrouterApiKey, openaiApiKey, vllmApiKey) are stripped. A checkbox
    opts into including them for full backups.
  - Import settings.json — opens an open dialog, validates the file as a
    JSON object, then REPLACES the entire store with the file contents.
    A confirmation dialog warns that absent keys (including API keys, if
    the export was sanitized) will be cleared.

Both sections are gated by developerMode, inherited from the Developer
tab itself.

Backend:
- commands/settings_io.rs with settings_export(include_secrets: bool)
  and settings_import() Tauri commands, both gated on developer mode
- shared_types/settings_io.rs with ExportResult / ImportResult (specta
  generates the matching TS types automatically)

Frontend:
- ai-models-tab.tsx: Evolution Limits subsection removed; max iterations
  and max build attempts props dropped
- settings-dialog.tsx: matching cleanup of unused form fields and the
  form.Field wrappers that fed AiModelsTab
- developer-tab.tsx: two new sections; loads tuning values via direct
  tauriAPI.ui.getPrefs() rather than the form, keeping the storybook
  story self-contained
- Snapshots updated for ai-models-tab and developer-tab

Closes: nixmac-cqb

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Member Author

cooper (czxtm) commented May 28, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • automerge - adds this PR to the back of the merge queue
  • urgent - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 28, 2026

Fails
🚫

Your ## Test Plan section is empty. Describe the steps a reviewer should take to verify this change.

🚫

New Rust modules were added without tests. Add a #[cfg(test)] mod tests { … } block or a file under apps/native/src-tauri/tests/:

  • apps/native/src-tauri/src/commands/settings_io.rs
  • apps/native/src-tauri/src/shared_types/settings_io.rs
Warnings
⚠️ Please assign this PR to someone (usually yourself).
⚠️ ❗ Big PR (532 lines changed). Consider splitting it into smaller, focused changes.

📋 PR Overview

Lines changed 532 (+409 / -123)
Files 2 added, 12 modified, 0 deleted
Draft / WIP no
Has Test Plan yes
New UI components no
New Storybook stories no
New Rust modules yes (2)
New TS source files no
New tests no
package.json touched no
Cargo.toml touched no
Infra / CI touched no

🔬 Coverage

Report Lines Statements Functions Branches
apps/native/coverage/coverage-summary.json 17.8% 17.8% 30.9% 54.1%

Generated by 🚫 dangerJS against b29d532

@czxtm
Copy link
Copy Markdown
Member Author

Superseded by the rebuilt Graphite stack starting at #244 and ending at #255.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant