Week2 2 #4
Open
Week2 2 #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yousifS
reviewed
Oct 22, 2018
| // using System.Collections.Generic; | ||
| // using System.Linq; | ||
| using System.Text; | ||
|
|
yousifS
reviewed
Oct 22, 2018
| sentence = Console.ReadLine(); | ||
|
|
||
| foreach (string text in sentence.Split()) | ||
| { |
There was a problem hiding this comment.
You are only handling the case when the vowel is in the first or second position.
yousifS
reviewed
Oct 24, 2018
|
|
||
| public static string CompareHands(string hand1, string hand2) | ||
| { | ||
| // Your code here |
There was a problem hiding this comment.
What is a different way to check for a tie?
yousifS
reviewed
Oct 24, 2018
| public static string CompareHands(string hand1, string hand2) | ||
| { | ||
| // Your code here | ||
| if (hand1 == "rock" && hand2 == "rock") |
There was a problem hiding this comment.
This method directly prints out to the console, I would like for this method to not do any user interaction, but return the appropriate value/result. And the calling method (Main in your case) handle the user interaction.
yousifS
reviewed
Oct 24, 2018
|
|
||
| return hand1 + ' ' + hand2; | ||
| } | ||
| // public static bool test() |
There was a problem hiding this comment.
I see the tests defined, but the way you implemented CompareHands, these tests would not work.
yousifS
reviewed
Nov 11, 2018
| public static void Main() | ||
| { | ||
| Console.WriteLine("Enter hand 1:"); | ||
| string hand1 = Console.ReadLine().ToLower(); |
There was a problem hiding this comment.
I dont see the try/catch block anywhere.
Owner
Author
|
It looks like my try catch is with my compare hand method. Did I have to use it somewhere else?
…Sent from my iPhone
On Nov 11, 2018, at 1:41 PM, yousifS ***@***.***> wrote:
@yousifS commented on this pull request.
In RockPaperScissors/RockPaperScissors.cs:
> @@ -8,18 +8,121 @@ public static void Main()
{
Console.WriteLine("Enter hand 1:");
string hand1 = Console.ReadLine().ToLower();
I dont see the try/catch block anywhere.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.