-
Notifications
You must be signed in to change notification settings - Fork 0
Zain/implement highlight UI v2 #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zainbilalh
wants to merge
13
commits into
main
Choose a base branch
from
Zain/implement-highlight-ui-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
296242d
refactored highlight logic into HighlightViewModel
zainbilalh 4f1fc2e
refactored HighlightViewModel
zainbilalh 34d2167
Added noHiglightView
zainbilalh 14ac665
passed HighlightViewModel as environment object
zainbilalh b5cecb1
attempt: make filter and search stick to top of screen
zainbilalh 600efc4
Added networking for articles
zainbilalh f26e312
Implemented networking for YouTubeVideos
zainbilalh 9d73e01
Changed fetch calls to be async
zainbilalh c5517a6
made all viewModel access patterns EnvironmentObject
zainbilalh 453f6d9
fixed date formatting
zainbilalh 6f4b976
Code style and naming fixes
zainbilalh 7144d41
Added youtubeVideo sport filter
zainbilalh e06e8da
Merge branch 'main' into Zain/implement-highlight-ui-v2
angelinaa-chen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| query Articles($sportsType: String) { | ||
| articles(sportsType: $sportsType) { | ||
| id | ||
| title | ||
| image | ||
| sportsType | ||
| publishedAt | ||
| url | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| query YoutubeVideos { | ||
| youtubeVideos { | ||
| id | ||
| title | ||
| description | ||
| thumbnail | ||
| b64Thumbnail | ||
| url | ||
| publishedAt | ||
| duration | ||
| sportsType | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.