-
Notifications
You must be signed in to change notification settings - Fork 0
Zain/implement highlight UI v2 #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
MrPeterss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work zain, just a couple of comments!
angelinaa-chen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR Zain! A couple comments, and maybe let's wait until back-end pushes their changes to test the sportsType filtering before merging. Otherwise, looks amazing :) great work!!
Added
HighlightsViewModelwith loading, filtering, and clean separation of highlights into structured lists for the views.Added
NoHighlightViewImplemented networking for fetching articles and YouTube videos.
(This looks like a big PR, but the lines of code mostly come from
HighlightsViewModel, which copies a lot of its structure from already existingGamesViewModelandPastGameViewModelNetworking:
I originally implemented both fetches using separate completion handlers, but since both are always needed, I switched to an async/await setup and grouped the calls.
This is my first time using async/await in Swift, so I’d appreciate extra attention on that part to make sure the approach is correct and safe.
Next Steps:
Logic:
- Update date formatting once the backend provides consistent date fields- Re-test filtering once sportsType values are fixed on the backendStyle
Other