chore(deps): upgrade gitlab client-go to v2.34.0#317
Merged
henrysachs merged 2 commits intoJun 2, 2026
Conversation
13 tasks
Collaborator
|
spec.forProvider.sentryEnabled is a breaking in-place API/CRD type change from string to boolean but i'm okay with breaking it for compatibility with the library itself. Would you be so kind and resolve the MR Conflicts so i can merge this? @BoxBoxJason |
Signed-off-by: BoxBoxJason <contact@boxboxjason.dev>
Signed-off-by: BoxBoxJason <contact@boxboxjason.dev>
BoxBoxJason
force-pushed
the
deps/upgrade-gitlab-sdk
branch
from
ef60866 to
6bf473d
Compare
Contributor
Author
|
Hey there @henrysachs ! I just performed the rebase. I even think this change is positive, that meant the field SentryEnabled was NOT reconciled, it will now be drift detected during observation (at the cost of a breaking change). Also the users can now use regular boolean values instead of stringified ones. |
Collaborator
|
@BoxBoxJason thank you so much! Great work as always. Keep it up 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR upgrades the gitlab client-go sdk to v2.34.0.
This is a major version upgrade, luckily, there was no major impact on this SDK, unlike the migration from v0 to v1.
There are two instances of the same deprecation that appeared, I marked them with a comment:
// deprecated but still needed for backward compatibilityThere were a few functions signature that changed to pass pointers instead of raw types. Those were fully migrated.
Closes #316
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
I did not test the provider against all resources, as this would be too difficult, but I ran it properly against my cluster, it works as is.