feat: support harbor project & group integration#315
Open
BoxBoxJason wants to merge 5 commits into
Open
Conversation
Contributor
Author
|
Requires #317 |
3e57f00 to
92e95ac
Compare
Collaborator
|
@BoxBoxJason could you rebase this one too? as your changes are now on master |
Signed-off-by: BoxBoxJason <contact@boxboxjason.dev>
Signed-off-by: BoxBoxJason <contact@boxboxjason.dev>
Signed-off-by: BoxBoxJason <contact@boxboxjason.dev>
Signed-off-by: BoxBoxJason <contact@boxboxjason.dev>
352f0c0 to
de03d02
Compare
Signed-off-by: BoxBoxJason <contact@boxboxjason.dev>
Contributor
Author
|
Hey there @henrysachs ! The rebase was just performed for this branch ! Thanks for your reviews ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds a new supported integration for projects & groups: Harbor.
This comes with two new managed resources (the project & group Harbor Integration) API declarations.
Creates complete abstract clients to interact with the gitlab API for these. (I tried mutualizing as much as I could the functions).
Creates the controller logic to handle and reconcile these new resources.
This comes packaged with a very complete unit tests coverage (mostly AI generated to achieve extensive testing). We have ~81% coverage on the controller functions & ~90% coverage on the clients functions.
Closes #314
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
I have:
unexpected drift. (should result in recreation of the resource if applicable)
unexpected drift. (should result in an update of the resource if applicable)