Skip to content

feat: support harbor project & group integration#315

Open
BoxBoxJason wants to merge 5 commits into
crossplane-contrib:masterfrom
BoxBoxJason:feat/harbor-integration
Open

feat: support harbor project & group integration#315
BoxBoxJason wants to merge 5 commits into
crossplane-contrib:masterfrom
BoxBoxJason:feat/harbor-integration

Conversation

@BoxBoxJason

@BoxBoxJason BoxBoxJason commented May 28, 2026

Copy link
Copy Markdown
Contributor

Description of your changes

This PR adds a new supported integration for projects & groups: Harbor.

This comes with two new managed resources (the project & group Harbor Integration) API declarations.
Creates complete abstract clients to interact with the gitlab API for these. (I tried mutualizing as much as I could the functions).
Creates the controller logic to handle and reconcile these new resources.

This comes packaged with a very complete unit tests coverage (mostly AI generated to achieve extensive testing). We have ~81% coverage on the controller functions & ~90% coverage on the clients functions.

Closes #314

I have:

  • Read and followed Crossplane's contribution process.
  • Followed the git conventional commit message format.
  • Made sure all changes are covered by proper tests, reaching a coverage of at least 80% when applicable.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

I have:

  • Successfully built and ran the provider locally against a kubernetes cluster.
  • Successfully created, updated, and deleted resources of the types I changed / created.
  • Ensured reconciliation loops for the changed / created resource complete without error.
    • Creation
    • Update
    • Deletion
  • Deleted the resource on the app side to ensure the provider correctly handles
    unexpected drift. (should result in recreation of the resource if applicable)
  • Updated the resource on the app side to ensure the provider correctly handles
    unexpected drift. (should result in an update of the resource if applicable)

@BoxBoxJason

Copy link
Copy Markdown
Contributor Author

Requires #317

@BoxBoxJason BoxBoxJason force-pushed the feat/harbor-integration branch from 3e57f00 to 92e95ac Compare May 28, 2026 12:33
@BoxBoxJason BoxBoxJason marked this pull request as ready for review May 28, 2026 13:25
@henrysachs

Copy link
Copy Markdown
Collaborator

@BoxBoxJason could you rebase this one too? as your changes are now on master

Signed-off-by: BoxBoxJason <contact@boxboxjason.dev>
Signed-off-by: BoxBoxJason <contact@boxboxjason.dev>
Signed-off-by: BoxBoxJason <contact@boxboxjason.dev>
Signed-off-by: BoxBoxJason <contact@boxboxjason.dev>
@BoxBoxJason BoxBoxJason force-pushed the feat/harbor-integration branch from 352f0c0 to de03d02 Compare June 2, 2026 19:31
Signed-off-by: BoxBoxJason <contact@boxboxjason.dev>
@BoxBoxJason

BoxBoxJason commented Jun 2, 2026

Copy link
Copy Markdown
Contributor Author

Hey there @henrysachs !

The rebase was just performed for this branch !

Thanks for your reviews !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Project & Group level Harbor integrations

2 participants