Skip to content

fix: replace raw echo with standard output helpers in git/update-repos-personal#661

Merged
credfeto merged 3 commits into
mainfrom
fix/652-echo-helpers-update-repos-personal
Jun 5, 2026
Merged

fix: replace raw echo with standard output helpers in git/update-repos-personal#661
credfeto merged 3 commits into
mainfrom
fix/652-echo-helpers-update-repos-personal

Conversation

@dnyw4l3n13
Copy link
Copy Markdown
Collaborator

@dnyw4l3n13 dnyw4l3n13 commented Jun 5, 2026

Summary

  • Fix shebang spacing (#! /bin/sh#!/bin/sh)
  • Replace the non-standard die() function with the project-standard implementation using coloured printf output directed to stderr
  • Add info() helper function and replace raw echo "Script Dir: $BASEDIR" with info "Script Dir: $BASEDIR"

Closes #652

Test plan

  • shellcheck passes on the updated script
  • checkbashisms passes on the updated script
  • Script behaviour is preserved — only output formatting changed

…s-personal

Replace the non-standard die() function and raw echo calls with the
project-standard die/info/success helpers using coloured printf output.
Also fix shebang spacing (#! /bin/sh → #!/bin/sh).

Closes #652

Prompt: Work on issue #652 in credfeto/scripts - replace raw echo with output helpers (die, info, success) in git/update-repos-personal
@dnyw4l3n13 dnyw4l3n13 self-assigned this Jun 5, 2026
@dnyw4l3n13 dnyw4l3n13 added AI-Work Work for an AI Agent Urgent Urgent Priority labels Jun 5, 2026
@dnyw4l3n13
Copy link
Copy Markdown
Collaborator Author

Status

Changes are committed and pushed. PR is in draft.

CI is running — build-pre-release is pending. Will mark ready once all checks pass.

credfeto
credfeto previously approved these changes Jun 5, 2026
success() was added but is never called in this script; the script
delegates to fetch which handles its own success output per repo.
@dnyw4l3n13 dnyw4l3n13 marked this pull request as ready for review June 5, 2026 17:49
@dnyw4l3n13
Copy link
Copy Markdown
Collaborator Author

Status: Ready for Review

All CI checks passed. Code review complete. PR marked ready.

Changes

  • 3e7cdc3a — Replace non-standard die() and raw echo with standard die/info helpers; fix shebang spacing
  • 2a212e59 — Remove unused success() function (not called anywhere in this script; fetch handles its own per-repo output)
  • 35183efe — CHANGELOG entry added

@credfeto
Copy link
Copy Markdown
Owner

credfeto commented Jun 5, 2026

Super-linter summary

Language Validation result
BASH Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@dnyw4l3n13
Copy link
Copy Markdown
Collaborator Author

Status: Complete

All CI checks passing. PR body updated to accurately reflect the final changes (the success() function was added then removed in the refactor commit — the body now reflects only info() and die() as the helpers in the script).

No outstanding review comments or CHANGES_REQUESTED reviews. PR is ready for merge.

@credfeto credfeto enabled auto-merge June 5, 2026 17:54
@credfeto
Copy link
Copy Markdown
Owner

credfeto commented Jun 5, 2026

Super-linter summary

Language Validation result
BASH Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@credfeto credfeto merged commit 8d0649c into main Jun 5, 2026
68 checks passed
@credfeto credfeto deleted the fix/652-echo-helpers-update-repos-personal branch June 5, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI-Work Work for an AI Agent Urgent Urgent Priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace raw echo with output helpers in git/update-repos-personal

2 participants