notifications: Add support for watch timed mute options (1 hour, Today)#85
notifications: Add support for watch timed mute options (1 hour, Today)#85asyba wants to merge 5 commits intocoredevices:masterfrom
Conversation
|
There is a minor problem related to the database, not sure yet how to handle. |
|
ping @sjp4 |
| @@ -1,8 +1,8 @@ | |||
| { | |||
| "formatVersion": 1, | |||
There was a problem hiding this comment.
27.json shouldn't be changed in this PR - that's why you were seeing migration problems (you probably did a build which changed the schema before changing the database version to 28). You'll need to rebase on the latest main (db version is now 33), and revert these changes to the schema json, then update the version to 34, compile, and checking those json changes
There was a problem hiding this comment.
I see now how I have to deal with database changes, thanks for explain to me.
| } | ||
| val anyContactMuted = notification.people.any { it.muteState == MuteState.Always } | ||
| val anyContactStarred = notification.people.any { it.muteState == MuteState.Exempt } | ||
| // Check if mute has expired |
There was a problem hiding this comment.
This code path is never hit, right? (because there's no way to configure the temperary mute on android)
There was a problem hiding this comment.
No, we can't set the temporary mute on the app for the moment.
Only from the watch, but for Android the filter to decide if the notification should be sent or not it's done in the android app, so that is why I added this in this class.
but I don't have an android to test this specifically, maybe it's not used and needs to be removed??
Compare to ios that the filter decide can be done only in the watch since notification are sent directly to there.
There was a problem hiding this comment.
Yes - we never sync that database with the watch on android, so these could never be set (unless there was a UI built to do that)
asyba
force-pushed
the
notification_mute_day
branch
from
17e6f85 to
186e880
Compare
asyba
force-pushed
the
notification_mute_day
branch
from
186e880 to
1cc3972
Compare
3 participants
Implement the temporary mute functionality for notifications.
This allows to support the new mute options (1 hour, Today) that pebble has.
For the moment is just for sync the status between databases.
PebbleOS PR: coredevices/PebbleOS#651