Skip to content

fix: preserve leading dot in ls tool path resolution #10515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zerone0x wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −4
Open

fix: preserve leading dot in ls tool path resolution #10515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions core/tools/implementations/lsTool.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@ export function resolveLsToolDirPath(dirPath: string | undefined) {
if (!dirPath || dirPath === ".") {
return ".";
}
// Don't strip leading slash from absolute paths - let the resolver handle it
if (dirPath.startsWith(".") && !dirPath.startsWith("./")) {
return dirPath.slice(1);
}
return dirPath.replace(/\\/g, "/");
}

Expand Down
13 changes: 13 additions & 0 deletions core/tools/implementations/lsTool.vitest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,19 @@ test("resolveLsToolDirPath preserves forward slashes", () => {
expect(resolveLsToolDirPath("path/to/dir")).toBe("path/to/dir");
});

test("resolveLsToolDirPath preserves hidden directory paths", () => {
expect(resolveLsToolDirPath(".continue/rules")).toBe(".continue/rules");
});

test("resolveLsToolDirPath preserves hidden directory name only", () => {
expect(resolveLsToolDirPath(".git")).toBe(".git");
});

test("resolveLsToolDirPath preserves parent directory references", () => {
expect(resolveLsToolDirPath("..")).toBe("..");
expect(resolveLsToolDirPath("../foo")).toBe("../foo");
});

test("lsToolImpl truncates output when entries exceed MAX_LS_TOOL_LINES", async () => {
// Generate more than MAX_LS_TOOL_LINES entries (which is 200)
const mockEntries = Array.from({ length: 250 }, (_, i) => `file${i}.txt`);
Expand Down
Loading