fix: preserve leading dot in ls tool path resolution#10515
Open
zerone0x wants to merge 1 commit intocontinuedev:mainfrom
Open
fix: preserve leading dot in ls tool path resolution#10515zerone0x wants to merge 1 commit intocontinuedev:mainfrom
zerone0x wants to merge 1 commit intocontinuedev:mainfrom
Conversation
The `resolveLsToolDirPath` function incorrectly stripped leading dots from paths like `.continue/rules`, converting them to `continue/rules` which doesn't exist. This broke the ls tool for any hidden directory. Remove the faulty condition that matched paths starting with "." but not "./" and stripped their first character. The path resolver handles these paths correctly without preprocessing. Fixes continuedev#10466 Co-Authored-By: Claude <noreply@anthropic.com>
dosubot
bot
added
the
size:S
|
All contributors have signed the CLA ✍️ ✅ |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the
lstool failing when called with hidden directory paths like.continue/rules.The
resolveLsToolDirPathfunction had a condition that matched paths starting with.(but not./) and stripped the leading character viaslice(1). This converted.continue/rulestocontinue/rules, which doesn't exist, causing the tool to error with "Directory not found."The fix removes this faulty condition. The downstream
resolveInputPathandresolveRelativePathInDirfunctions handle dot-prefixed paths correctly without any preprocessing.Fixes #10466
Checklist
Tests
.continue/rules) are preserved.git) are preserved..,../foo) are preservedlsTooltests pass🤖 Generated with Claude Code (issue-hunter-pro)
Continue Tasks: ✅ 1 no changes — View all
Summary by cubic
Preserves leading dots in ls tool path resolution so hidden directories (.continue/rules, .git) and parent refs (.., ../foo) work without errors. Removed the stripping logic and added tests to cover these cases.
Written for commit deac90f. Summary will update on new commits.