Skip to content

libimage: treat localhost/ images as local-only #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mehrdadbn9 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

libimage: treat localhost/ images as local-only #660

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b840a7a
libimage: treat localhost/ images as local-only
mehrdadbn9 Feb 12, 2026
db5d321
libimage: treat localhost/ images as local-only
mehrdadbn9 Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions common/libimage/pull.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,6 +501,18 @@ func (r *Runtime) copySingleImageFromRegistry(ctx context.Context, imageName str
}
}

// Images prefixed with "localhost/" (without a port) are local-only by
// convention and cannot be pulled from a remote registry. Return the
// local image if available, or an error if not found, without ever
// attempting a network pull (see containers/podman/issues/28038).
if isLocalhostImage(imageName) {
if localImage != nil {
logrus.Debugf("Image %s is a localhost image, returning local image", imageName)
return localImage, nil
}
return nil, fmt.Errorf("%s: %w", imageName, storage.ErrImageUnknown)
}

customPlatform := len(options.Architecture)+len(options.OS)+len(options.Variant) > 0
if customPlatform && pullPolicy != config.PullPolicyAlways && pullPolicy != config.PullPolicyNever {
// Unless the pull policy is always/never, we must
Expand Down Expand Up @@ -659,3 +671,11 @@ func (r *Runtime) copySingleImageFromRegistry(ctx context.Context, imageName str

return nil, resolved.FormatPullErrors(pullErrors)
}

// isLocalhostImage returns true if the image name refers to a localhost-only
// image (i.e., prefixed with "localhost/" but without a port number).
// Images with "localhost:PORT/" are actual registry references and should
// not be treated as local-only.
func isLocalhostImage(name string) bool {
return strings.HasPrefix(name, "localhost/")
}