libimage: treat localhost/ images as local-only #660
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where images prefixed with
localhost/(without a port) were incorrectly treated as remote Docker registry references, causingpodman buildto fail with:Problem
Images named with
localhost/prefix (e.g.,localhost/base-toolbox:latest) are a naming convention for local-only images in Podman/Buildah. They should never attempt a network pull from a Docker registry.Previously, when building an image with
FROM localhost/base-toolbox:latestin a Containerfile, the code would:neweroralways, attempt to pull fromdocker://localhost/base-toolbox:latestlocalhostwithout a port is not a real Docker registrySolution
Added a check in
copySingleImageFromRegistry()to detectlocalhost/prefixed image names (without a port) and:storage.ErrImageUnknownif not foundThis prevents any network pull attempts for localhost images.
Testing
The fix can be verified by:
localhost/base:latestFROM localhost/base:latestin its ContainerfileFixes: containers/podman#28038